wtclaude
43215b49a0
All checks were successful
PR Checks / android-build (pull_request) Successful in 10m44s
Fix the SonarQube coverage gate (0% on new code) — a reporting gap, not a testing gap: the JVM unit suite already exists but the source-only scan never received a coverage report. - app/build.gradle.kts: apply jacoco, enable debug unit-test coverage, add a jacocoTestReport task (excludes generated/Hilt/Compose-singleton classes) - sonar-project.properties: consume the JaCoCo XML; exclude pure-@Composable UI from coverage (JVM unit tests can't execute composable bodies) - .gitea/workflows/sonarqube.yml: run JDK 17 + Android SDK + `testDebugUnitTest jacocoTestReport` before the scan Also clear the three actionable code smells: remove an unused import (AdminContentScreen), remove an unused parameter (AdminSupportScreen. RespondDialog), and decompose LoginViewModel.submit() (cognitive complexity 20 -> under 15). The remaining 12 smells (snake_case DTO fields that mirror the JSON wire contract; Compose/nav complexity) are marked Won't Fix in SonarQube with rationale. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NgyHnrNa8WwG3doxvxjuCr
46 lines
2.2 KiB
Properties
46 lines
2.2 KiB
Properties
# SonarQube analysis config for the Android-app repo.
|
|
# Consumed by the scanner in .gitea/workflows/sonarqube.yml on push to main.
|
|
# The project key must match the one created in SonarQube (dashboard URL
|
|
# ?id=Runic-Gateway-Android-app).
|
|
|
|
sonar.projectKey=Runic-Gateway-Android-app
|
|
sonar.projectName=runic gateway android app
|
|
|
|
# Analysed application code. The single :app module's Kotlin sources.
|
|
# SonarQube's Kotlin analyzer works on source directly, so no compiled classes
|
|
# or Gradle build are required for the scan.
|
|
sonar.sources=app/src/main
|
|
|
|
# Local unit tests (app/src/test). Instrumented tests (app/src/androidTest) can
|
|
# be added here once that source set exists.
|
|
sonar.tests=app/src/test
|
|
|
|
# Never analyse build output, Gradle internals, or generated code.
|
|
sonar.exclusions=**/build/**,**/.gradle/**,**/generated/**
|
|
|
|
sonar.sourceEncoding=UTF-8
|
|
|
|
# ── Coverage (JaCoCo) ──
|
|
# sonarqube.yml runs `./gradlew testDebugUnitTest jacocoTestReport` before the scan;
|
|
# that task (app/build.gradle.kts) writes this XML. Without it, Sonar reports 0%
|
|
# coverage even though the JVM unit suite (app/src/test) exists.
|
|
sonar.coverage.jacoco.xmlReportPaths=app/build/reports/jacoco/jacocoTestReport/jacocoTestReport.xml
|
|
|
|
# Exclude from *coverage* (not from analysis): pure-@Composable UI can't be exercised
|
|
# by JVM unit tests without Robolectric, so counting those lines would unfairly sink
|
|
# new-code coverage. Logic (ViewModels, repositories, core, DTOs) stays measured.
|
|
sonar.coverage.exclusions=\
|
|
app/src/main/java/**/ui/**/*Screen.kt,\
|
|
app/src/main/java/**/ui/**/*Screen*.kt,\
|
|
app/src/main/java/**/ui/theme/**,\
|
|
app/src/main/java/**/RunicApp.kt,\
|
|
app/src/main/java/**/MainActivity.kt,\
|
|
app/src/main/java/**/*Application.kt
|
|
|
|
# ── Optional enrichment (enable once produced in CI) ──
|
|
# • Android Lint: ./gradlew lintDebug → app/build/reports/lint-results-debug.xml
|
|
# sonar.androidLint.reportPaths=app/build/reports/lint-results-debug.xml
|
|
# The alternative to the CLI scanner used here is the SonarQube Gradle plugin
|
|
# (org.sonarqube), which auto-discovers these reports; the CLI + properties file
|
|
# is used instead to keep this repo's setup identical to website/ and link/.
|