diff --git a/book/02-website-module.md b/book/02-website-module.md index 46ec21c..cbda1f5 100644 --- a/book/02-website-module.md +++ b/book/02-website-module.md @@ -566,6 +566,14 @@ That paragraph exists because the kit's acceptance run ([`kit-acceptance.md`][acceptance]) built a module by following this chapter to the letter, and its page rendered outside the site. Everything else it wrote was right. +**And check a component's prop names against [§3.4][api] rather than guessing +them.** `PageHeader` takes `eyebrow`, `title`, `lead` and `center` — a page that +passes `subtitle` renders its heading and nothing under it, because an unknown +prop on a React component is silently dropped. Nothing warns, in the console or +anywhere else; the page simply looks emptier than every core page around it. This +template shipped exactly that mistake until a run of it against a real core was +looked at, which is the only way that class of thing is ever found. + **It is curated and closed, not a re-export of core's component library.** Adding to it is a minor version bump, and so is adding an optional prop to a member; changing an existing prop is a major one. diff --git a/template/client/src/routes/public/Clan.jsx b/template/client/src/routes/public/Clan.jsx index e9976d4..371c1dd 100644 --- a/template/client/src/routes/public/Clan.jsx +++ b/template/client/src/routes/public/Clan.jsx @@ -47,7 +47,7 @@ export default function Clan() { <> {/* Core's per-Team notification control lands here — ABOVE the roster, diff --git a/template/client/src/routes/public/Clans.jsx b/template/client/src/routes/public/Clans.jsx index 28ac029..0c098c5 100644 --- a/template/client/src/routes/public/Clans.jsx +++ b/template/client/src/routes/public/Clans.jsx @@ -18,7 +18,7 @@ export default function Clans() { return ( - + {loading && } {error && } @@ -34,7 +34,9 @@ export default function Clans() { {clan.name}{clan.abbr ? ` [${clan.abbr}]` : ''} - — {clan.memberCount} members + + {' '}— {clan.memberCount} member{clan.memberCount === 1 ? '' : 's'} + ))} diff --git a/template/client/src/routes/public/WorldStatus.jsx b/template/client/src/routes/public/WorldStatus.jsx index a4b1a67..346bf47 100644 --- a/template/client/src/routes/public/WorldStatus.jsx +++ b/template/client/src/routes/public/WorldStatus.jsx @@ -48,7 +48,12 @@ export default function WorldStatus() { {loading && }