The kit was pinned to website 963d734 -- MODULE_API 1.6.0, the Teams cutover --
and the platform is on 1.9.0. Three registrations and two calls arrived in
between, and a reader building against this book would have found no mention of
any of them: a module can now declare what its game can announce, and never who
is told.
Moving `ci/core-ref.json` is the mechanism for exactly this. The pin is now
66bb3b9a (website `main`, the engagement cutover) and `template/module.json`
declares `^1.9.0`.
What chapter 2 gained, under "Telling core something happened":
* a TRIGGER is a payload contract, not a notification stream -- the two share
one id namespace and are constantly confused;
* `ceiling` is required, has no default, and is a CONTAINMENT tree rather than
a size ladder (a `staff` ceiling does not permit `owner`);
* an AUDIENCE resolver returns user ids and nothing else, resolves to NOBODY
on failure, and takes CONSTANT params -- the constraint worth knowing before
you design around it;
* templates re-ensure per seedVersion, rule groups are offered ONCE per group
key, so a rule appended to an existing group reaches fresh installs only;
* `ctx.events.emit` binds the owner and is fire-and-forget; `ctx.inbox.push`
is the direct write, for when there is nothing for an operator to decide.
The template builds all of it: one trigger, one audience over the clan roster it
already had, one seeded body and one seeded rule group, and an emitter in
`boot.js` that fires on the TRANSITION rather than on the poll. Seven new tests,
including the audience that resolves to nobody when its query throws.
Three claims were wrong and are corrected here rather than shipped:
* core validates `subjectKey` against the declared variables and refuses the
module; the draft taught a cooldown keyed on `undefined`, which the check
exists to prevent and a reader will never see.
* `emit` throws OUTSIDE production and only drops-and-logs inside it. Teaching
the second half alone leaves a developer meeting a throw the book says
cannot happen.
* the seeded body itself was malformed -- heading `level: 2` where the block
registry takes 'h2', and no block ids at all.
The third is the one worth keeping: `registerEngagementSeeds` checks that
`blocks` is a non-empty array and stops, so that body would have registered,
seeded, and failed the first time an operator opened it. Found by running the
template's `register()` through core's real registry at the pinned ref -- which
CI does not do, and cannot: the template job checks the version and runs the
template against fakes. A fake accepts what core refuses. The gap is now named
in the chapter, beside the code, and in the pin's own comment, and the rule that
bit has a test that fails on it.
Also: `checkLinks` skipped `.core/`. Bumping this pin means cloning core into
that directory first, and the walk then reported nine broken links in someone
else's README. CI never saw it -- the clone happens in the `template` job and
the check runs in `prose` -- so it was a failure only a person could meet.
Co-Authored-By: Claude <noreply@anthropic.com>
125 lines
5.6 KiB
JavaScript
125 lines
5.6 KiB
JavaScript
// ── Test doubles for what core hands the module ───────────────────────────
|
|
//
|
|
// Your server half is testable WITHOUT core, and that is not a convenience — it
|
|
// is the contract holding. Everything a module may touch arrives on `ctx`
|
|
// (MODULE_API.md §2.3), so a `ctx` this file can build is a complete statement of
|
|
// what your module depends on. **If a test ever needs something that is not here,
|
|
// either your module reached past the boundary or §2.3 needs a new member.** Both
|
|
// are worth stopping for.
|
|
//
|
|
// The fake mirrors §2.3 member for member — including the freezing, so a module
|
|
// that assigns to `ctx.something` fails here the way it would in core.
|
|
//
|
|
// This file lives under `test/`, which `checkImports.js` treats as not-shipped —
|
|
// which is why it may `require('express')` when the module's own routers may not.
|
|
// It builds a REAL express Router on purpose: a fake Router would only ever test
|
|
// the fake.
|
|
|
|
const express = require('express')
|
|
|
|
/** Records every call, so a test can assert what the module asked for. */
|
|
function spy(returns) {
|
|
const fn = (...args) => {
|
|
fn.calls.push(args)
|
|
return typeof returns === 'function' ? returns(...args) : returns
|
|
}
|
|
fn.calls = []
|
|
return fn
|
|
}
|
|
|
|
function fakeLog() {
|
|
return { error: spy(), warn: spy(), info: spy(), debug: spy() }
|
|
}
|
|
|
|
function fakeCtx(overrides = {}) {
|
|
// `freeze: false` is a test seam for a suite that wants to adjust the ctx it
|
|
// installed. Core always freezes; the unfrozen variant is never a claim about
|
|
// what a module is handed in production.
|
|
const { freeze = true, ...rest } = overrides
|
|
const logs = []
|
|
const ctx = {
|
|
moduleId: 'examplegame',
|
|
paths: { moduleRoot: require('path').resolve(__dirname, '..', '..') },
|
|
express,
|
|
validator: {},
|
|
db: { query: spy(Promise.resolve([])), pool: {} },
|
|
log: (namespace) => {
|
|
const log = fakeLog()
|
|
logs.push({ namespace, log })
|
|
return log
|
|
},
|
|
auth: { getUserFromRequest: spy(null) },
|
|
// The engagement seam (§2.3). One method, recording, because that is the
|
|
// whole of what a module may do with it: fire a declared event and stop.
|
|
// Core's own emit is fire-and-forget and returns nothing, so this does too —
|
|
// a fake that returned a receipt would invite a module to wait on one.
|
|
events: { emit: spy(undefined) },
|
|
middleware: {
|
|
requireAuth: (req, res, next) => next(),
|
|
requireRole: () => (req, res, next) => next(),
|
|
siteMode: (req, res, next) => next(),
|
|
validate: (req, res, next) => next(),
|
|
noindex: (req, res, next) => next(),
|
|
// The factory returns a pass-through rather than a real limiter: a test
|
|
// that tripped a rate limit would be a test whose result depended on how
|
|
// many times the suite had run.
|
|
rateLimit: (options) => Object.assign((req, res, next) => next(), { options }),
|
|
accountChangeLimiter: (req, res, next) => next(),
|
|
},
|
|
site: { baseUrl: 'http://localhost:5173' },
|
|
...rest,
|
|
}
|
|
// Non-enumerable, and that is not tidiness. Core freezes every object value on
|
|
// `ctx` one level deep, so an enumerable recorder hung off it would be frozen
|
|
// by the loop below and every `log.info` would throw on push. Keeping it out of
|
|
// the enumeration also makes the fake more faithful: a module iterating `ctx`
|
|
// sees §2.3's members and nothing a test put there.
|
|
Object.defineProperty(ctx, 'logs', { value: logs, enumerable: false })
|
|
if (!freeze) return ctx
|
|
for (const value of Object.values(ctx)) {
|
|
if (value && typeof value === 'object') Object.freeze(value)
|
|
}
|
|
return Object.freeze(ctx)
|
|
}
|
|
|
|
/**
|
|
* The registration api, recording rather than mounting.
|
|
*
|
|
* Copies core's `once()` rule (§2.4: "calling twice is an error"), so a module
|
|
* that registers the same thing twice fails in its own suite rather than first on
|
|
* an operator's install.
|
|
*/
|
|
function fakeApi() {
|
|
const record = {
|
|
routes: null, extensions: [], streams: null, legs: [], hooks: {}, teamProvider: null,
|
|
triggers: null, audiences: null, engagementSeeds: null,
|
|
}
|
|
const called = new Set()
|
|
const once = (name) => {
|
|
if (called.has(name)) throw new Error(`${name}() called twice`)
|
|
called.add(name)
|
|
}
|
|
const api = {
|
|
registerRoutes(mounts) { once('registerRoutes'); record.routes = mounts },
|
|
registerExtension(slot, router) { record.extensions.push({ slot, router }) },
|
|
registerNotificationStreams(streams) { once('registerNotificationStreams'); record.streams = streams },
|
|
registerAnnounceLeg(leg) { record.legs.push(leg) },
|
|
registerPostHook(hook) { once('registerPostHook'); record.hooks.post = hook },
|
|
// `once` here is not the general rule restated — it is a DIFFERENT rule that
|
|
// happens to look the same. The others may not be called twice by ONE module;
|
|
// this one holds a single value across the whole deployment, so a second
|
|
// module registering a provider collides with the first. A fake cannot see
|
|
// the second module, and asserting the half it can see is still worth doing.
|
|
registerTeamProvider(provider) { once('registerTeamProvider'); record.teamProvider = provider },
|
|
registerEventTriggers(triggers) { once('registerEventTriggers'); record.triggers = triggers },
|
|
registerAudiences(audiences) { once('registerAudiences'); record.audiences = audiences },
|
|
registerEngagementSeeds(seeds) { once('registerEngagementSeeds'); record.engagementSeeds = seeds },
|
|
onBoot(fn) { once('onBoot'); record.hooks.onBoot = fn },
|
|
onShutdown(fn) { once('onShutdown'); record.hooks.onShutdown = fn },
|
|
}
|
|
api.record = record
|
|
return api
|
|
}
|
|
|
|
module.exports = { fakeCtx, fakeApi, spy }
|