The kit was pinned to website 963d734 -- MODULE_API 1.6.0, the Teams cutover --
and the platform is on 1.9.0. Three registrations and two calls arrived in
between, and a reader building against this book would have found no mention of
any of them: a module can now declare what its game can announce, and never who
is told.
Moving `ci/core-ref.json` is the mechanism for exactly this. The pin is now
66bb3b9a (website `main`, the engagement cutover) and `template/module.json`
declares `^1.9.0`.
What chapter 2 gained, under "Telling core something happened":
* a TRIGGER is a payload contract, not a notification stream -- the two share
one id namespace and are constantly confused;
* `ceiling` is required, has no default, and is a CONTAINMENT tree rather than
a size ladder (a `staff` ceiling does not permit `owner`);
* an AUDIENCE resolver returns user ids and nothing else, resolves to NOBODY
on failure, and takes CONSTANT params -- the constraint worth knowing before
you design around it;
* templates re-ensure per seedVersion, rule groups are offered ONCE per group
key, so a rule appended to an existing group reaches fresh installs only;
* `ctx.events.emit` binds the owner and is fire-and-forget; `ctx.inbox.push`
is the direct write, for when there is nothing for an operator to decide.
The template builds all of it: one trigger, one audience over the clan roster it
already had, one seeded body and one seeded rule group, and an emitter in
`boot.js` that fires on the TRANSITION rather than on the poll. Seven new tests,
including the audience that resolves to nobody when its query throws.
Three claims were wrong and are corrected here rather than shipped:
* core validates `subjectKey` against the declared variables and refuses the
module; the draft taught a cooldown keyed on `undefined`, which the check
exists to prevent and a reader will never see.
* `emit` throws OUTSIDE production and only drops-and-logs inside it. Teaching
the second half alone leaves a developer meeting a throw the book says
cannot happen.
* the seeded body itself was malformed -- heading `level: 2` where the block
registry takes 'h2', and no block ids at all.
The third is the one worth keeping: `registerEngagementSeeds` checks that
`blocks` is a non-empty array and stops, so that body would have registered,
seeded, and failed the first time an operator opened it. Found by running the
template's `register()` through core's real registry at the pinned ref -- which
CI does not do, and cannot: the template job checks the version and runs the
template against fakes. A fake accepts what core refuses. The gap is now named
in the chapter, beside the code, and in the pin's own comment, and the rule that
bit has a test that fails on it.
Also: `checkLinks` skipped `.core/`. Bumping this pin means cloning core into
that directory first, and the walk then reported nine broken links in someone
else's README. CI never saw it -- the clone happens in the `template` job and
the check runs in `prose` -- so it was a failure only a person could meet.
Co-Authored-By: Claude <noreply@anthropic.com>
162 lines
6.1 KiB
JavaScript
162 lines
6.1 KiB
JavaScript
#!/usr/bin/env node
|
|
// Every relative link in this repo's markdown must resolve to a file that exists,
|
|
// and every in-page anchor must match a heading in the file it points at.
|
|
//
|
|
// WHAT THIS DOES NOT DO: fetch anything. External URLs are not checked, on
|
|
// purpose. This kit points at a self-hosted Gitea, so an HTTP check would fail on
|
|
// a runner without credentials, flake when the host is busy, and teach us to
|
|
// ignore red. What breaks in practice is a relative path after a file moves, and
|
|
// that is answerable offline with certainty.
|
|
//
|
|
// It DOES check that every http(s) link into the RunicGateway host names a
|
|
// branch, because `.../src/branch/main/...` survives and `.../src/commit/<sha>/...`
|
|
// pins a reader to a snapshot of a document we want them reading the current
|
|
// version of.
|
|
//
|
|
// Usage: node scripts/checkLinks.js (repo root)
|
|
// node scripts/checkLinks.js --quiet
|
|
|
|
const fs = require('fs')
|
|
const path = require('path')
|
|
|
|
const { stripFences } = require('./lib/markdown')
|
|
|
|
const ROOT = path.resolve(__dirname, '..')
|
|
const QUIET = process.argv.includes('--quiet')
|
|
|
|
// Directories that hold no prose we own. `.core` and `core` are core's own
|
|
// checkout: .gitignore reserves both because moving `ci/core-ref.json` means
|
|
// cloning core in here first, and without this that clone hands the reader nine
|
|
// broken links in somebody else's README the moment they follow the pin-bump
|
|
// instructions. CI never saw it — the clone happens in the `template` job and
|
|
// this check runs in `prose` — which is exactly the kind of failure that only
|
|
// ever meets a person.
|
|
const SKIP_DIRS = new Set(['.git', 'node_modules', 'dist', '.core', 'core'])
|
|
|
|
/** Every markdown file in the repo, repo-relative, sorted. */
|
|
function markdownFiles(dir = ROOT, out = []) {
|
|
for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
|
|
if (entry.isDirectory()) {
|
|
if (SKIP_DIRS.has(entry.name)) continue
|
|
markdownFiles(path.join(dir, entry.name), out)
|
|
} else if (entry.name.toLowerCase().endsWith('.md')) {
|
|
out.push(path.relative(ROOT, path.join(dir, entry.name)).split(path.sep).join('/'))
|
|
}
|
|
}
|
|
return out.sort()
|
|
}
|
|
|
|
// Fenced code blocks are stripped before links are read (`lib/markdown.js`): a
|
|
// fence can legitimately contain a path that does not exist — a directory listing
|
|
// of a project the reader has not created yet — and flagging those would make the
|
|
// check useless in exactly the document type this repo is made of.
|
|
|
|
/** Inline `[text](target)` links and `[ref]: target` definitions, with line numbers. */
|
|
function linksIn(text) {
|
|
const found = []
|
|
const lines = stripFences(text).split(/\r?\n/)
|
|
lines.forEach((line, i) => {
|
|
// Skip inline code spans: `[a](b)` inside backticks is an example, not a link.
|
|
const bare = line.replace(/`[^`]*`/g, '')
|
|
for (const m of bare.matchAll(/\[[^\]]*\]\(([^)\s]+)(?:\s+"[^"]*")?\)/g)) {
|
|
found.push({ target: m[1], line: i + 1 })
|
|
}
|
|
const def = /^\s{0,3}\[[^\]]+\]:\s*(\S+)/.exec(bare)
|
|
if (def) found.push({ target: def[1], line: i + 1 })
|
|
})
|
|
return found
|
|
}
|
|
|
|
/** GitHub/Gitea-style heading slugs, for anchor checking. */
|
|
function anchorsIn(text) {
|
|
const slugs = new Set()
|
|
for (const line of stripFences(text).split(/\r?\n/)) {
|
|
const m = /^\s{0,3}#{1,6}\s+(.*?)\s*#*\s*$/.exec(line)
|
|
if (!m) continue
|
|
const slug = m[1]
|
|
.replace(/`/g, '')
|
|
.replace(/\[([^\]]*)\]\([^)]*\)/g, '$1')
|
|
.toLowerCase()
|
|
.replace(/[^\w\s-]/gu, '')
|
|
.trim()
|
|
.replace(/\s+/g, '-')
|
|
if (slug) slugs.add(slug)
|
|
}
|
|
return slugs
|
|
}
|
|
|
|
const files = markdownFiles()
|
|
const anchorCache = new Map()
|
|
function anchorsOf(relPath) {
|
|
if (!anchorCache.has(relPath)) {
|
|
anchorCache.set(relPath, anchorsIn(fs.readFileSync(path.join(ROOT, relPath), 'utf8')))
|
|
}
|
|
return anchorCache.get(relPath)
|
|
}
|
|
|
|
const problems = []
|
|
let checked = 0
|
|
|
|
for (const file of files) {
|
|
const text = fs.readFileSync(path.join(ROOT, file), 'utf8')
|
|
const selfAnchors = anchorsIn(text)
|
|
|
|
for (const { target, line } of linksIn(text)) {
|
|
const where = `${file}:${line}`
|
|
|
|
if (/^(mailto:|tel:)/i.test(target)) continue
|
|
|
|
if (/^https?:\/\//i.test(target)) {
|
|
checked++
|
|
// Not fetched — but a permalink to a moving document is still wrong.
|
|
if (/gitea\.whitlocktech\.com\/.*\/src\/commit\//.test(target)) {
|
|
problems.push(`${where}: links to a commit snapshot, not a branch — ${target}`)
|
|
}
|
|
continue
|
|
}
|
|
|
|
if (target.startsWith('#')) {
|
|
checked++
|
|
const slug = decodeURIComponent(target.slice(1)).toLowerCase()
|
|
if (!selfAnchors.has(slug)) problems.push(`${where}: no heading matches ${target}`)
|
|
continue
|
|
}
|
|
|
|
checked++
|
|
const [rawPath, rawAnchor] = target.split('#')
|
|
// A PR/issue template's text is INLINED into a pull request or issue body, and
|
|
// Gitea resolves relative links in those against the repo root — not against
|
|
// `.gitea/`, where the file itself lives. So `[CONTRIBUTING.md](CONTRIBUTING.md)`
|
|
// is correct in a template and would be wrong anywhere else. Resolve those from
|
|
// the root, or this check reports every template link as broken and gets muted.
|
|
const base = file.startsWith('.gitea/') ? ROOT : path.dirname(path.join(ROOT, file))
|
|
const resolved = path.resolve(base, decodeURIComponent(rawPath))
|
|
const rel = path.relative(ROOT, resolved).split(path.sep).join('/')
|
|
|
|
if (rel.startsWith('..')) {
|
|
problems.push(`${where}: points outside the repo — ${target}`)
|
|
continue
|
|
}
|
|
if (!fs.existsSync(resolved)) {
|
|
problems.push(`${where}: no such file — ${target}`)
|
|
continue
|
|
}
|
|
if (rawAnchor && resolved.toLowerCase().endsWith('.md')) {
|
|
const slug = decodeURIComponent(rawAnchor).toLowerCase()
|
|
if (!anchorsOf(rel).has(slug)) {
|
|
problems.push(`${where}: ${rawPath} has no heading matching #${rawAnchor}`)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if (problems.length) {
|
|
console.error(`checkLinks: ${problems.length} problem(s) in ${files.length} file(s):\n`)
|
|
for (const p of problems) console.error(` ${p}`)
|
|
process.exit(1)
|
|
}
|
|
|
|
if (!QUIET) {
|
|
console.log(`checkLinks: ${checked} link(s) across ${files.length} markdown file(s) — OK`)
|
|
}
|