RunicGateway/Module-Rust
3
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 4 Wiki Activity

feat(zones): a blank dome stack is 3 spheres, not 1 (runicnpc 9e, D326)
All checks were successful
PR Checks / server-tests (pull_request) Successful in 32s
Details
PR Checks / frozen-manifest (pull_request) Successful in 1m13s
Details
PR Checks / client-build (pull_request) Successful in 7m49s
Details

Browse Source 
The org lead chose 3 by eye at noon in RunicNPC's 9d player session. The
zone step sends it when its stack is left blank, and the field's hint says
so. The wire is unchanged: the module always sends a stack, and the bridge's
own default for a dome without one stays 1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY
This commit is contained in:
claude
2026-10-09 01:24:19 -05:00
parent 4ad38d443b
commit e1789c1df4
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
server/eventWorld.js
View File

@@ -60,6 +60,8 @@ const ZONE_MAX_RADIUS = 150
const ZONE_MAX_MINUTES = 7 * 24 * 60 const ZONE_MAX_MINUTES = 7 * 24 * 60
const ZONE_MESSAGE_MAX = 256 const ZONE_MESSAGE_MAX = 256
const DOME_STACK_MAX = 10 const DOME_STACK_MAX = 10
/** A blank stack: 3 spheres, chosen by eye at noon in RunicNPC's 9d player session (D326). */
const DOME_STACK_DEFAULT = 3
/** /**
* ZoneDomes' own sphere types, by the number its API takes (D194). Only Standard * ZoneDomes' own sphere types, by the number its API takes (D194). Only Standard
@@ -725,7 +727,7 @@ const ACTIONS = [
description: description:
'A ZoneDomes dome over the zone. "standard" is a full shaded dome; the colours show only where the sphere meets the ground or a building. Needs ZoneDomes and RunicGatewayDomes.cs on the server. Blank is no dome.', 'A ZoneDomes dome over the zone. "standard" is a full shaded dome; the colours show only where the sphere meets the ground or a building. Needs ZoneDomes and RunicGatewayDomes.cs on the server. Blank is no dome.',
}, },
{ name: 'domeStack', type: 'int', required: false, example: 1, description: `How many spheres the dome stacks, 1 to ${DOME_STACK_MAX}; more is darker. Left blank, 1.` }, { name: 'domeStack', type: 'int', required: false, example: DOME_STACK_DEFAULT, description: `How many spheres the dome stacks, 1 to ${DOME_STACK_MAX}; more is darker. Left blank, ${DOME_STACK_DEFAULT}.` },
], ],
async perform({ runId, idempotencyKey, params, verify }) { async perform({ runId, idempotencyKey, params, verify }) {
@@ -777,7 +779,7 @@ const ACTIONS = [
} }
const missing = domeMissing(mods) const missing = domeMissing(mods)
if (missing) return { ok: false, retry: false, error: missing } if (missing) return { ok: false, retry: false, error: missing }
dome = { type: kind.type, stack: stack === undefined ? 1 : stack } dome = { type: kind.type, stack: stack === undefined ? DOME_STACK_DEFAULT : stack }
} }
// The dry run stops here, and has checked everything it can without the // The dry run stops here, and has checked everything it can without the

10
server/test/zones.test.js
View File

@@ -224,6 +224,16 @@ test('a zone crosses with its flags, settings, messages in the chat voice, and i
}) })
}) })
test('a dome with its stack left blank stacks 3 spheres (D326)', async (t) => {
stubZones(t, { servers: [server('main', { domes: PATCHED })] })
const calls = stubWorld(t)
const result = await action('rust.zone.open').perform({
runId: 7, idempotencyKey: 'k', params: { monument: 'main/a', radius: 40, minutes: 5, dome: 'standard', domeStack: '' },
})
assert.strictEqual(result.ok, true, result.error)
assert.deepStrictEqual(calls[0].body.dome, { type: 0, stack: 3 })
})
test('a zone with no options crosses exactly as it always did', async (t) => { test('a zone with no options crosses exactly as it always did', async (t) => {
stubZones(t) stubZones(t)
const calls = stubWorld(t) const calls = stubWorld(t)