fix(admin): no decision numbers in admin copy, and "1 player holds one" #59

wtclaude · 2026-10-22T15:28:48-05:00

wtclaude commented

2026-10-22 15:28:48 -05:00

Two copy defects I found while writing the runicgateway.com Rust docs (runicgateway.com#35). You asked for them fixed.

Decision numbers an operator reads

I found two on the walk: "(D189)" on a group's Servers tab, and "(D198)" in the not imported yet tooltip. Searching every non-comment line found 24 strings in all, each carrying a number like "(D189)" or "(D257, D270)":

Permissions.jsx: the group Servers tab text, and the not imported yet tooltip;
the event editor's step-field and budget descriptions (eventWorld, eventRewards, eventLeases), and two option sources;
the Reward by console command skipped note in a run's detail;
five NPC profile validation errors (npcProfile.js, npcs.model.js).

Each number is removed and the sentence around it is unchanged. Kept on purpose: the descriptions in server/swagger/doc.js (developer-facing, the API spec) and every code comment.

"Last pushed: 1 player hold one."

On Admin → Rust servers, the line now says "holds" for one and "hold" otherwise. No test covers it: the summary lives in a .jsx file, and the client tests only import plain modules.

Tests

Two tests pinned the old wording (commandSteps, npcs); they now assert the text.

All pass locally:

server: 705/705 tests, plus check:imports, check:bundle, check:swagger and check:engagement;
client: build, 99/99 tests, and check:externals.

No protocol, schema or API change.

AI-assisted: Claude Code (Claude Opus 5.5)

🤖 Generated with Claude Code

https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY

Two copy defects I found while writing the runicgateway.com Rust docs (runicgateway.com#35). You asked for them fixed. ## Decision numbers an operator reads I found two on the walk: "(D189)" on a group's *Servers* tab, and "(D198)" in the *not imported yet* tooltip. Searching every non-comment line found **24** strings in all, each carrying a number like "(D189)" or "(D257, D270)": - `Permissions.jsx`: the group *Servers* tab text, and the *not imported yet* tooltip; - the event editor's step-field and budget descriptions (`eventWorld`, `eventRewards`, `eventLeases`), and two option sources; - the *Reward by console command* skipped note in a run's detail; - five NPC profile validation errors (`npcProfile.js`, `npcs.model.js`). Each number is removed and the sentence around it is unchanged. **Kept on purpose:** the descriptions in `server/swagger/doc.js` (developer-facing, the API spec) and every code comment. ## "Last pushed: 1 player hold one." On Admin → Rust servers, the line now says "holds" for one and "hold" otherwise. No test covers it: the summary lives in a `.jsx` file, and the client tests only import plain modules. ## Tests Two tests pinned the old wording (`commandSteps`, `npcs`); they now assert the text. All pass locally: - server: 705/705 tests, plus `check:imports`, `check:bundle`, `check:swagger` and `check:engagement`; - client: build, 99/99 tests, and `check:externals`. No protocol, schema or API change. - [x] AI-assisted: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY

wtclaude added 1 commit 2026-10-22 15:28:49 -05:00

fix(admin): no decision numbers in admin copy, and "1 player holds one"

PR Checks / client-build (pull_request) Successful in 34s

Details

PR Checks / frozen-manifest (pull_request) Successful in 1m3s

Details

PR Checks / server-tests (pull_request) Successful in 7m12s

Details

3741c954f5

Twenty-four strings an administrator reads carried an internal decision
number - "(D189)", "(D198)", "(D257, D270)" and the like: the permission
screen's group Servers tab and a chip tooltip, the event editor's step
field and budget descriptions, two option sources, a command reward's
skipped note, and five NPC profile validation errors. A D-number means
something to the plan, never to an operator. Each is removed, and the
sentence around it left as it was. The developer-facing swagger
descriptions and code comments keep theirs.

The servers page's chat-title line read "Last pushed: 1 player hold
one." It now says "holds" for one.

Two tests pinned the old wording and now assert the text instead.

Found while writing the runicgateway.com Rust docs (its PLAN.md §16,
phase 15).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY

whitlocktech merged commit 2e80a21597 into edge

2026-10-22 15:32:55 -05:00

whitlocktech deleted branch fix/admin-copy

2026-10-22 15:32:56 -05:00

whitlocktech referenced this issue from a commit

2026-10-22 15:32:57 -05:00

Merge pull request 'fix(admin): no decision numbers in admin copy, and "1 player holds one"' (#59) from fix/admin-copy into edge

wtclaude referenced this pull request

2026-10-23 01:56:48 -05:00

release: weapon names and the admin copy fixes (v0.5.1) #61

Sign in to join this conversation.