fix(rust): answer refusals in the field core reads, and show the name the game last saw #7

wtclaude · 2026-09-21T22:34:53Z

wtclaude commented

2026-09-21 22:34:53 +00:00

The two defects the phase 6 browser walk found and #6 described — but did not carry. They were written and walked, and left uncommitted; edge still has both shapes the walk condemned.

Every refusal sentence was invisible

Core's request primitive reads one field:

const message = (data && data.message) || res.statusText || 'Request failed'

This module has answered { error: … } since phase 1, and got away with it because every failure until phase 6 landed in ErrorState on a page whose whole content was missing — where a generic sentence is honest. A form is different: the sentence IS the outcome. The link page showed Service Unavailable for all four of the refusals phase 6 exists to write, including the one that must never be ambiguous (unsure — "your code is still good, a server was unreachable" vs. "that code is wrong").

All 23 error bodies now answer in message, which is core's Error schema — the one these routes' own #swagger.responses already referenced, so the annotations stop being a claim the handlers contradict.

test/errorShape.test.js drives each outcome rather than grepping for the field, and asserts the half that is easy to leave behind: a body carrying both fields renders correctly in a browser and keeps the wrong shape alive for the next route that copies it. It also asserts the five outcomes stay five distinct sentences.

The player saw a stale name

/player/rust showed the name recorded at link time while the admin panel showed the one the game last saw — the same person labelled two ways on one site, because a Rust name changes on a whim and only the admin read joined rust_players. A LEFT JOIN, because an account can be linked and never played on.

Checks

123 server tests, 39 client tests, check:imports, check:bundle, check:swagger, check:externals — all green. No route shapes changed, so swagger-fragment.json and routes.manifest.json are unchanged and current.

Base branch

edge, per D18.

AI disclosure

This contribution was AI-assisted (Claude Code).

🤖 Generated with Claude Code

https://claude.ai/code/session_01PMH6bw1jXMgbyF3ZWGEzSM

The two defects the phase 6 browser walk found and #6 described — but did not carry. They were written and walked, and left uncommitted; `edge` still has both shapes the walk condemned. ## Every refusal sentence was invisible Core's request primitive reads **one** field: ```js const message = (data && data.message) || res.statusText || 'Request failed' ``` This module has answered `{ error: … }` since phase 1, and got away with it because every failure until phase 6 landed in `ErrorState` on a page whose whole content was missing — where a generic sentence is honest. **A form is different: the sentence IS the outcome.** The link page showed *Service Unavailable* for all four of the refusals phase 6 exists to write, including the one that must never be ambiguous (`unsure` — "your code is still good, a server was unreachable" vs. "that code is wrong"). All 23 error bodies now answer in `message`, which is core's `Error` schema — the one these routes' own `#swagger.responses` already referenced, so the annotations stop being a claim the handlers contradict. `test/errorShape.test.js` drives each outcome rather than grepping for the field, and asserts the half that is easy to leave behind: **a body carrying both fields renders correctly in a browser** and keeps the wrong shape alive for the next route that copies it. It also asserts the five outcomes stay five distinct sentences. ## The player saw a stale name `/player/rust` showed the name recorded at link time while the admin panel showed the one the game last saw — the same person labelled two ways on one site, because a Rust name changes on a whim and only the admin read joined `rust_players`. A `LEFT JOIN`, because an account can be linked and never played on. ## Checks 123 server tests, 39 client tests, `check:imports`, `check:bundle`, `check:swagger`, `check:externals` — all green. No route shapes changed, so `swagger-fragment.json` and `routes.manifest.json` are unchanged and current. ## Base branch `edge`, per D18. ## AI disclosure - [x] This contribution was AI-assisted (Claude Code). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01PMH6bw1jXMgbyF3ZWGEzSM

wtclaude added 1 commit 2026-09-21 22:34:56 +00:00

fix(rust): answer refusals in the field core reads, and show the name the game last saw

PR Checks / server-tests (pull_request) Successful in 15s

Details

PR Checks / frozen-manifest (pull_request) Successful in 48s

Details

PR Checks / client-build (pull_request) Successful in 7m49s

Details

0876a1d568

The two defects the phase 6 browser walk found and #6 described but did not
carry. They were written, walked and left uncommitted; `edge` still has the
shapes the walk condemned.

**Every refusal sentence was invisible.** Core's request primitive reads one
field — `(data && data.message) || res.statusText` — and this module has
answered `{ error: … }` since phase 1. It got away with it because every
failure until phase 6 landed in `ErrorState` on a page whose whole content was
missing, where a generic sentence is honest. A form is different: the sentence
IS the outcome, and the link page showed *Service Unavailable* for all four of
the refusals phase 6 exists to write. All 23 bodies now answer in `message` —
core's `Error` schema, which these routes' own `#swagger.responses` already
referenced, so the annotations stop being a claim the handlers contradict.

`test/errorShape.test.js` drives each outcome rather than grepping for the
field, and asserts the half that is easy to leave behind: a body carrying BOTH
fields renders correctly in a browser and keeps the wrong shape alive for the
next route that copies it.

**The player saw a stale name.** `/player/rust` showed the name recorded at
link time while the admin panel showed the one the game last saw — the same
person labelled two ways on one site, because a Rust name changes on a whim and
only the admin read joined `rust_players`. A LEFT JOIN, because an account can
be linked and never played on.

123 server tests, 39 client tests, `check:imports`, `check:bundle`,
`check:swagger`, `check:externals` — all green.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PMH6bw1jXMgbyF3ZWGEzSM

whitlocktech merged commit a1b6d155a1 into edge

2026-09-21 22:39:45 +00:00

whitlocktech deleted branch fix/phase-6-refusal-sentences

2026-09-21 22:39:45 +00:00

whitlocktech referenced this issue from a commit

2026-09-21 22:39:46 +00:00

Merge pull request 'fix(rust): answer refusals in the field core reads, and show the name the game last saw' (#7) from fix/phase-6-refusal-sentences into edge

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RunicGateway/Module-Rust#7