wtclaude
baffaa46c9
R1's identity link, site-side, and R13's first extension slot. A player types /link in game, the plugin hands them a six-character code privately, and they enter it here; the site records who owns which Steam account, and an operator sees that on core's own `/admin/users/:id` page. **The site is the author of record and the game holds nothing.** There is no per-account store in Rust that survives a wipe, and phase 7 needs the site authoritative anyway — it pushes permissions INTO the game keyed by Steam id. A copy in the game would be a second thing to reconcile every wipe, for no question it could answer better. ## D24 — a code is minted by ONE server, so every server is asked Nothing in six characters says where it came from. The fleet is asked in turn and the first `link.ok` wins; the others answer `unknown` and nothing happens there, because a code is only spent at the server that actually holds it. Asking the player to pick was rejected: a wrong pick would come back indistinguishable from a wrong code, and that is the one refusal which must not be ambiguous. **"Every reachable server refused" is not the same answer as "a server was unreachable."** Collapsing them tells a player whose server is down that their code is wrong — so they run /link again on that same server and are told the same thing for as long as it stays down. `unsure` is that case, and it says to try again rather than to fetch a new code. ## D23 — a Steam id another account holds is refused, never moved The primary key is `steam_id`, and it is load-bearing rather than tidy: phase 7 grants permissions against a link and phase 13 hangs entitlements off it, so a silent move is an account takeover performed by typing six characters. The refusal names the holder, because the advice is unusable without it. The INSERT is a plain INSERT for the same reason — `ON DUPLICATE KEY UPDATE` here would BE that move — and the duplicate-key error is the refusal for the race the check above cannot close. The way out is `/unlink` in game, which reaches the site off the ingest feed rather than through a route (the plugin has no link to delete). D25 adds the other way out: staff can sever a link from the admin panel, for a player who cannot reach that Steam account in game. ## The slot, and the hole it found in this repo's own generator `admin.users.detail` is declared in `module.json` AND registered in `index.js` AND filled by the chunk — three places, because the server half and the client half are different registrations that share one name. `swaggerFragment.js` knew only about tier routers, so the two routes under `/admin/users/:id` were generated by nothing: a fragment that was internally consistent and described two routes fewer than the module serves. A slot's mount is core's and cannot be derived here, so it is a fourth constant beside `TIER_BASE` — held to account by the frozen-manifest job, which was verified to catch exactly this by removing the two paths and watching it fail. ## Smaller things worth knowing - **Core's `useAsync` has no `refresh`.** A counter in the deps is how a page re-reads after its own write; it blanks while it re-reads, which is right here and is exactly what made it wrong for a poll. - **Every player-portal nav row needs an `icon`** — core draws one on every row, and the client suite says so. This module had no icons file until now, because the public header is text buttons. - The two new frame kinds are STAFF-only. Neither carries a code, but both name a Steam id beside a website account's activity, and that join is not a public fact about what happened on a server. - The link code route carries its own rate limiter rather than core's `accountChangeLimiter`: this is guessing somebody else's secret, not changing your own password, and a shared counter would let one policy set the other. Protocol 3 on all three declaration sites; 17 new tests, 136 green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PMH6bw1jXMgbyF3ZWGEzSM
74 lines
4.0 KiB
JavaScript
74 lines
4.0 KiB
JavaScript
// ── The `admin.users.detail` extension slot ───────────────────────────────
|
||
//
|
||
// R13's first slot, and the phase criterion in one file: *an operator sees the
|
||
// Steam id inside core's own user page*.
|
||
//
|
||
// MODULE_API.md §2.4's fourth mount shape — module routes hanging off a CORE
|
||
// resource. `/admin/users/:id` is a URL core owns and this module has something
|
||
// to say about it, so the routes cannot move behind a `/rust` prefix and cannot
|
||
// be registered anywhere else either. Core declares the slot; a module fills it,
|
||
// and only one module may.
|
||
//
|
||
// Three things about this router that are not true of the other three:
|
||
//
|
||
// • **`mergeParams: true`**, because the user id belongs to the parent. Without
|
||
// it `req.params.id` is undefined and every statement here silently scopes to
|
||
// nothing.
|
||
// • **The paths keep the module's own segment** (`/rust/links`, not `/links`).
|
||
// Core owns the resource and other modules may fill their own slots on other
|
||
// resources; a bare `/links` would be this module claiming a word on a URL it
|
||
// does not own.
|
||
// • **The gate is stricter than the admin tier's.** Core's users router is
|
||
// `requireRole('admin')` and the slot is mounted inside it, so editors and
|
||
// moderators never reach here — which is right for a surface that can sever
|
||
// what phases 7 and 13 grant against.
|
||
//
|
||
// The client half is registered under the SAME name (`registry.registerExtension`
|
||
// in `entry.jsx`) and builds its own client for these two routes; a slot passes a
|
||
// component `userId` and nothing else.
|
||
|
||
const core = require('../../core')
|
||
|
||
const express = core.express
|
||
const { param } = core.validator
|
||
|
||
const usersRust = require('./usersRust.controller')
|
||
const { validate } = core.middleware
|
||
|
||
// Same bound the player tier states, for the same reason: nothing but digits
|
||
// reaches a `WHERE steam_id = ?`.
|
||
const STEAM_ID_RE = /^[0-9]{5,32}$/
|
||
|
||
const usersRustRouter = express.Router({ mergeParams: true })
|
||
|
||
usersRustRouter.get(
|
||
'/rust/links',
|
||
// #swagger.tags = ['Admin · Users']
|
||
// #swagger.summary = 'A user’s linked Steam accounts and their Rust record (admin only)'
|
||
// #swagger.description = 'Every Steam account linked to this website user, with the display name the game last saw and, per server, all-time kills / deaths / playtime across every wipe. Fills the admin.users.detail extension slot.'
|
||
// #swagger.security = [{ "cookieAuth": [] }, { "bearerAuth": [] }]
|
||
// #swagger.parameters['id'] = { in: 'path', required: true, schema: { type: 'integer' }, description: 'User id.' }
|
||
/* #swagger.responses[200] = { description: 'Linked accounts', content: { "application/json": { schema: { $ref: "#/components/schemas/RustAdminLinkList" } } } } */
|
||
param('id').isInt(),
|
||
validate,
|
||
usersRust.listLinks,
|
||
)
|
||
|
||
usersRustRouter.delete(
|
||
'/rust/links/:steamId',
|
||
// #swagger.tags = ['Admin · Users']
|
||
// #swagger.summary = 'Sever a user’s Steam link (admin only)'
|
||
// #swagger.description = 'Staff release a link on this user’s behalf. It is the counterweight to the site refusing to move a Steam id another account holds: a player who cannot reach that Steam account in game has no other way back. Recorded in the activity log.'
|
||
// #swagger.security = [{ "cookieAuth": [] }, { "bearerAuth": [] }]
|
||
// #swagger.parameters['id'] = { in: 'path', required: true, schema: { type: 'integer' }, description: 'User id.' }
|
||
// #swagger.parameters['steamId'] = { in: 'path', required: true, schema: { type: 'string' }, description: 'The Steam id to release.' }
|
||
/* #swagger.responses[200] = { description: 'Unlinked', content: { "application/json": { schema: { type: "object", properties: { unlinked: { type: "boolean", example: true } } } } } } */
|
||
/* #swagger.responses[404] = { description: 'Not linked to this user', content: { "application/json": { schema: { $ref: "#/components/schemas/Error" } } } } */
|
||
param('id').isInt(),
|
||
param('steamId').matches(STEAM_ID_RE),
|
||
validate,
|
||
usersRust.removeLink,
|
||
)
|
||
|
||
module.exports = usersRustRouter
|