wtclaude
22fd8c5da7
Phase 4. `/rust` is the server list and the module's landing page (D12);
`/rust/servers/:id` is one server with four tabs — feed, leaderboard, who is
on, wipes (D13). Everything selectable lives in the URL, so any view of the
page is a link. The feed and the presence list poll every twenty seconds while
the tab is visible and not at all when it is not (D14); the leaderboard and the
wipe list load once. `site.footer.status` is filled with a live server and
player count (D15).
Nothing on these pages calls a game server. Every field comes from this
module's own tables, which is what the phase criterion is about: the site
renders the last thing each server said while every server is off.
Walking that criterion in a browser against a live rig found four defects, two
of them already shipped in phase 3:
* An unreachable refresh called `putState` — the whole-row write — with two
fields, so a host that rebooted lost its hostname, map, size, seed and wipe
id. The list then read "Offline" with nothing beside it, which is not "here
is what we know" but "we have never heard of it". `markUnreachable` now
moves three columns and mentions no others.
* "Last reported" read `updated_at`, which a FAILED poll writes too — so an
offline server claimed it had reported just now, every thirty seconds, for
as long as it stayed down. `last_seen_at` is the new column, moved only by a
frame that arrived.
* Feed rows showed a bare time of day, so three events from six weeks ago all
read as this afternoon once the feed was filtered to a past wipe.
* `/rust/servers/typo` rendered core's ErrorState under its own heading and
read "No such server / Something went wrong", sending a reader who mistyped
a URL looking for an outage.
Also: a detail route (`GET …/servers/:id`), because it is the only route under
that path that can say a server does not exist — the other four answer an empty
list for an id nobody configured, and each of those is a good answer to its own
question.
`useAsync` cannot poll: it blanks its data on every dependency change, so a
twenty-second refresh built on it would clear the killfeed and re-fill it four
times a minute. `hooks/usePolled.js` is the module's own, invisible when it
succeeds and keeping the rows when it fails.
The client test fake was *nearly* core — it prefixed routes without stripping
the trailing separator, so the first module to register an index route failed
the nav check for a link that works in a browser. It now copies core's line
character for character.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016wDDVXWMDz82WqE1i969r4
97 lines
4.3 KiB
JavaScript
97 lines
4.3 KiB
JavaScript
// ── Formatting ────────────────────────────────────────────────────────────
|
|
//
|
|
// Small functions, and the tests are small too — but three of them guard claims
|
|
// that would otherwise be made by a page that looks fine: an unknown duration
|
|
// rendered as zero, a timestamp in the wrong unit, and "in 0 seconds".
|
|
//
|
|
// Locale-dependent output is asserted loosely on purpose. `Intl` formats to the
|
|
// RUNNER's locale, and a test pinned to "3 minutes ago" would be a test that
|
|
// fails on a machine set to French while the page it describes is correct.
|
|
|
|
import test from 'node:test'
|
|
import assert from 'node:assert/strict'
|
|
|
|
import { ago, clock, count, day, duration, prefab, shortId } from '../src/lib/format.js'
|
|
|
|
const NOW = Date.parse('2026-09-16T12:00:00Z')
|
|
|
|
test('a relative time picks the unit that fits', () => {
|
|
assert.match(ago(NOW - 3 * 60_000, NOW), /3/)
|
|
assert.match(ago(NOW - 5 * 3600_000, NOW), /5/)
|
|
assert.match(ago(NOW - 3 * 86400_000, NOW), /3/)
|
|
})
|
|
|
|
test('"just now" rather than "in 0 seconds"', () => {
|
|
// What `numeric: 'auto'` produces under a minute is not what anybody means,
|
|
// and a feed row a few seconds old is the commonest row on the page.
|
|
assert.equal(ago(NOW, NOW), 'just now')
|
|
assert.equal(ago(NOW - 10_000, NOW), 'just now')
|
|
})
|
|
|
|
test('both time shapes this module serves are accepted', () => {
|
|
// `updatedAt` is an ISO string the model produced; an event's `t` is the
|
|
// millisecond stamp the plugin put on the frame. A helper that took only one
|
|
// would be a helper every caller has to remember the type for.
|
|
assert.equal(ago('2026-09-16T11:57:00.000Z', NOW), ago(NOW - 3 * 60_000, NOW))
|
|
})
|
|
|
|
test('a missing time is "never", not the epoch', () => {
|
|
assert.equal(ago(null), 'never')
|
|
assert.equal(ago(undefined), 'never')
|
|
assert.equal(ago(''), 'never')
|
|
assert.equal(day(null), 'unknown')
|
|
})
|
|
|
|
test('an unknown duration is a dash, and a short one keeps its seconds', () => {
|
|
// The distinction the plugin makes and this must not lose: `sessionSec` is
|
|
// ABSENT for a player who was already on when it loaded, so zero and unknown
|
|
// arrive at the same function and must not render the same way.
|
|
assert.equal(duration(null), '—')
|
|
assert.equal(duration(0), '—')
|
|
assert.equal(duration(40), '40s')
|
|
assert.equal(duration(90), '2m')
|
|
assert.equal(duration(3720), '1h 2m')
|
|
assert.equal(duration(7200), '2h')
|
|
})
|
|
|
|
test('a prefab reads as words, without a lookup table', () => {
|
|
assert.equal(prefab('rifle.ak'), 'rifle ak')
|
|
assert.equal(prefab('scientistnpc_full_any'), 'scientistnpc full any')
|
|
assert.equal(prefab(null), '')
|
|
})
|
|
|
|
test('a steam id is shortened without pretending to be a name', () => {
|
|
assert.equal(shortId('76561198000000001'), '…000001')
|
|
assert.equal(shortId(''), '')
|
|
})
|
|
|
|
test('a count that is not a number is zero, never NaN on the page', () => {
|
|
assert.equal(count(undefined), '0')
|
|
assert.equal(count(null), '0')
|
|
})
|
|
|
|
test("a feed row from another day carries its date, not just a time", () => {
|
|
// Found by the page walk: with the feed filtered to the previous wipe, three
|
|
// events from six weeks ago rendered as `02:03 PM` and read as this afternoon.
|
|
// Today's rows stay bare, because a killfeed of today's fights does not want
|
|
// the date on every line.
|
|
// Asserted against `Intl` rather than against a literal: a 12-hour locale puts
|
|
// letters in a bare time ("05:30 AM"), so "has letters in it" is not the test —
|
|
// "is exactly the time, and nothing else" is.
|
|
const time = (at) => new Date(at).toLocaleTimeString(undefined, { hour: '2-digit', minute: '2-digit' })
|
|
|
|
const todayAt = NOW - 90 * 60_000
|
|
assert.equal(clock(todayAt, NOW), time(todayAt))
|
|
|
|
const olderAt = NOW - 46 * 86400_000
|
|
assert.ok(clock(olderAt, NOW).endsWith(time(olderAt)))
|
|
assert.ok(clock(olderAt, NOW).length > time(olderAt).length, 'an older row carries no date')
|
|
|
|
// Yesterday counts as another day even when it is only a few hours back — the
|
|
// boundary is the calendar, not a duration, because that is what a reader
|
|
// means by "what time was that".
|
|
const lateLastNight = Date.parse('2026-09-15T23:50:00')
|
|
const earlyToday = Date.parse('2026-09-16T00:20:00')
|
|
assert.ok(clock(lateLastNight, earlyToday).length > time(lateLastNight).length)
|
|
})
|