The module half of the read path. Seven tables, an ingest cursor, four public routes, and one file whose only job is deciding who may see what. **The record and the window are different things.** `rust_player_wipe_stats` and `rust_gather_totals` are permanent and per-wipe, so all-time is those rows SUMmed rather than a second set of counters that can disagree with them — that is R12's "per-wipe detail plus all-time rollups" in one table instead of two. `rust_events` is a bounded 30-day window of raw frames for the killfeed, and `rust_presence` is a board: replaced wholesale, never appended. **The feed is a cursor, not a socket, and the header says why.** Core runs Node 20, where a global WebSocket is still behind a flag, so a socket means taking `ws` — against a release that asserts it has no runtime dependencies (D5). The deciding argument is the other one though: a socket needs a cursor anyway, for whatever it missed while the module was restarting, and the catch-up path is the one that has to be right. A cursor alone is one mechanism exercised every five seconds rather than two where the second only runs after an outage. **The cursor advances after the batch, never before.** A crash between the two re-reads events already counted, which inflates a total; the other order loses them silently and for ever. One is visible and bounded, the other is invisible and permanent, so the code fails in the visible direction. A server with no cursor starts at the sidecar's current END rather than at zero — replaying a fortnight of deaths into stats for wipes the site never saw is not a catch-up. **`catalogue.js` is a security boundary, default-deny.** Protocol 2 carries IP addresses (login attempts, approvals, bans), one player's report about another, and the grid reference of somebody's base. They are stored, because an operator chasing ban evasion needs them; they are not served below the admin tier. The allowlist lives here rather than as a field on the wire, because a boundary declared by the sender is one a compromised or merely out-of-date game host can widen — the same reason core's own shard fan-out filters on the serving side. A kind this build has never heard of is not public, and a test holds the list against PROTOCOL.md §8.4 so that adding a kind to the protocol without classifying it fails a build. `PROTOCOL_VERSION` goes to 2 here in the same change as the emitters, though this module consumes none of the new frames yet: the sidecar refuses a mismatched client with a 409, so a module left on 1 would stop being able to read the board it has been reading all along. A constant that lags the deployment is an outage with a version number on it. 95 server tests, 20 client tests, every guard green, and `routes.manifest.json` regenerated against a real core at the pinned ref: 10 routes, all documented, none of core's moved. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016wDDVXWMDz82WqE1i969r4
163 lines
5.1 KiB
JavaScript
163 lines
5.1 KiB
JavaScript
// ── The read path's logic ─────────────────────────────────────────────────
|
|
//
|
|
// Everything that decides WHAT a caller gets, separated from the SQL that
|
|
// fetches it, so this file can be tested with no database and `events.db.js` has
|
|
// no branching to test.
|
|
//
|
|
// The decision that matters here is not a business rule, it is a boundary: what
|
|
// a signed-out visitor may see. Protocol 2 carries IP addresses and player
|
|
// reports, and the only thing standing between them and a public page is
|
|
// `catalogue.js`'s allowlist and the fact that **every read on this file takes an
|
|
// explicit viewer**. There is no default, because a default is what a caller
|
|
// gets when they forget — and the safe value is never the one that is easier to
|
|
// type.
|
|
|
|
const catalogue = require('../../catalogue')
|
|
const db = require('./events.db')
|
|
|
|
/** Hard ceiling on a page, whatever a caller asks for. */
|
|
const MAX_LIMIT = 200
|
|
|
|
function boundedLimit(requested, fallback = 50) {
|
|
const n = Number(requested)
|
|
if (!Number.isFinite(n) || n <= 0) return fallback
|
|
return Math.min(Math.trunc(n), MAX_LIMIT)
|
|
}
|
|
|
|
/**
|
|
* Parses a `kind` query parameter into a list.
|
|
*
|
|
* Accepts `?kind=player.death` and `?kind=player.death,player.chat`, and answers
|
|
* `null` for anything empty — which means "whatever this viewer may see" rather
|
|
* than "nothing", and is then narrowed by the catalogue.
|
|
*/
|
|
function parseKinds(raw) {
|
|
if (!raw) return null
|
|
|
|
const list = String(raw)
|
|
.split(',')
|
|
.map((k) => k.trim())
|
|
.filter(Boolean)
|
|
|
|
return list.length > 0 ? list : null
|
|
}
|
|
|
|
/**
|
|
* Recent events for one server, already narrowed to what this viewer may see.
|
|
*
|
|
* **`admin` is a parameter, not a default.** A route that forgets it gets the
|
|
* public list, which is the direction it is safe to be wrong in. And a kind the
|
|
* caller asked for that they may not see is dropped silently rather than
|
|
* refused: naming it in an error would confirm the kind exists, which is a small
|
|
* thing to leak and a free one to avoid.
|
|
*/
|
|
async function recent({ serverId, admin = false, kind = null, wipeId = null, limit }) {
|
|
const kinds = catalogue.kindsFor({ admin, requested: parseKinds(kind) })
|
|
|
|
// Every requested kind was refused. Answering with an empty list is right —
|
|
// the events they asked for are, as far as they are concerned, not there.
|
|
if (kinds.length === 0) return []
|
|
|
|
const rows = await db.recentEvents({
|
|
serverId,
|
|
kinds,
|
|
wipeId,
|
|
limit: boundedLimit(limit),
|
|
})
|
|
|
|
return rows.map(shape)
|
|
}
|
|
|
|
/**
|
|
* One stored row as an API object.
|
|
*
|
|
* `raw` comes back from the database as text and is parsed here rather than in
|
|
* the db layer, because a row whose JSON will not parse is a reporting problem
|
|
* and not a query problem: it answers with the envelope it does know and an
|
|
* empty body, instead of failing a whole page over one bad row.
|
|
*/
|
|
function shape(row) {
|
|
let frame = {}
|
|
|
|
try {
|
|
frame = typeof row.raw === 'string' ? JSON.parse(row.raw) : row.raw || {}
|
|
} catch {
|
|
frame = {}
|
|
}
|
|
|
|
return {
|
|
id: Number(row.id),
|
|
kind: row.kind,
|
|
t: Number(row.t),
|
|
wipeId: row.wipeId || null,
|
|
steamId: row.steamId || null,
|
|
frame,
|
|
}
|
|
}
|
|
|
|
/**
|
|
* The leaderboard for a server, per wipe or all-time.
|
|
*
|
|
* All-time is the same rows summed differently rather than a second set of
|
|
* counters, so the two can never disagree — which is the whole reason R12's
|
|
* "per-wipe detail plus all-time rollups" is one table and not two.
|
|
*/
|
|
async function leaderboard({ serverId, wipeId = null, sort = 'kills', limit }) {
|
|
const rows = await db.leaderboard({
|
|
serverId,
|
|
wipeId,
|
|
sort,
|
|
limit: boundedLimit(limit, 25),
|
|
})
|
|
|
|
return rows.map((r) => ({
|
|
steamId: r.steamId,
|
|
name: r.name || null,
|
|
kills: Number(r.kills) || 0,
|
|
deaths: Number(r.deaths) || 0,
|
|
npcKills: Number(r.npcKills) || 0,
|
|
structures: Number(r.structures) || 0,
|
|
playtimeSec: Number(r.playtimeSec) || 0,
|
|
lastSeen: r.lastSeen || null,
|
|
}))
|
|
}
|
|
|
|
/**
|
|
* Every wipe this server has had, newest first.
|
|
*
|
|
* The list is what makes the per-wipe view navigable, and it is also the proof
|
|
* R12 asks for: a wipe that ended is still here, with its stats still attached.
|
|
*/
|
|
async function wipes(serverId) {
|
|
const rows = await db.listWipes(serverId)
|
|
|
|
return rows.map((r) => ({
|
|
wipeId: r.wipeId,
|
|
saveCreatedAt: r.saveCreatedAt || null,
|
|
firstSeen: r.firstSeen,
|
|
lastSeen: r.lastSeen,
|
|
}))
|
|
}
|
|
|
|
/**
|
|
* Who is on the server right now.
|
|
*
|
|
* Read from the presence board rather than counted from connect and disconnect
|
|
* events: the board is re-sent on every bridge connect and every minute, so it
|
|
* is right even after this module has missed something. Counting transitions
|
|
* instead would drift, and drift in exactly the direction people notice —
|
|
* players who never left.
|
|
*/
|
|
async function online(serverId) {
|
|
const rows = await db.presenceFor(serverId)
|
|
|
|
return rows.map((r) => ({
|
|
steamId: r.steamId,
|
|
name: r.name || null,
|
|
sleeping: Boolean(r.sleeping),
|
|
connectedAt: r.connectedAt || null,
|
|
}))
|
|
}
|
|
|
|
module.exports = { recent, leaderboard, wipes, online, parseKinds, boundedLimit, MAX_LIMIT }
|