wtclaude
43147b796a
R2, and the first phase where this module WRITES to a game. Groups and grants are authored on the website and pushed into each server's own permission store, so every plugin that already calls `UserHasPermission` honours them with no adapter, and a wipe stops being a data-loss event. **Seven org-lead decisions (D28-D34).** A grant is keyed to the website USER and resolved to every Steam id they have linked at push time (D28); every authored row carries a scope — a server or `*` (D29); groups are mirrored as real groups rather than flattened (D30); a holder the site did not author is REPORTED, never undone, with adopt and revoke offered (D31); one verb, with the plugin diffing locally (D32); a permission no server has registered is reported unresolved and never self-registered (D33); authoring is people and groups by hand, with rules deferred (D34). **Three sets, and every interesting question is a difference between two.** `desired − pushed` is what to apply; `pushed − desired` is what to RETIRE, because the site put it there and has since withdrawn it; `present − desired` is drift. The middle one is why `rust_perm_pushed` exists: a name in the store that is not in the desired set is either something the site retired or something a human granted, and those two have opposite correct answers. **What lands is not what was sent.** A grant naming a permission the server has not registered did not land — `GrantUserPermission` no-ops silently — and a member the store has never seen could not be placed. Neither is recorded as pushed, so the site never believes it gave a privilege it did not. The loop asks a cheap question every thirty seconds — does the digest of the desired set still equal what this server last confirmed — and syncs on a change, a restart, a wipe, a drift hook, a failed attempt past its backoff, or the fifteen-minute audit that finds drift on a server nobody has touched. **This module's first admin page**, because a permission model is the first thing here that has to be composed rather than configured. What is on it is decided by what an operator can get wrong: four states are invisible from the game and from a list of grants, and each is a sentence rather than a number. Walked end to end against a real core at the pinned ref, the real sidecar, and a stand-in speaking protocol 4 — including a restart that emptied the store and was fully re-pushed. Four defects the browser found that 133 green tests did not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PMH6bw1jXMgbyF3ZWGEzSM
90 lines
3.6 KiB
JavaScript
90 lines
3.6 KiB
JavaScript
// ── The shape of the identity surface ─────────────────────────────────────
|
||
//
|
||
// Three properties that are invisible in review and expensive in production:
|
||
//
|
||
// • **the link route is rate-limited** (R1). Six characters from a 32-glyph
|
||
// alphabet is a good code only while a guesser is made to pay per attempt,
|
||
// and once phase 7 grants permissions against a link, guessing one is a
|
||
// privilege-escalation path rather than a nuisance.
|
||
// • **the extension router merges its parent's params**. Without
|
||
// `mergeParams`, `req.params.id` is `undefined` and every statement in that
|
||
// panel silently scopes to no user — a panel that reads as "this user has no
|
||
// Rust account" for everybody.
|
||
// • **the extension's paths keep the module's own segment.** Core owns
|
||
// `/admin/users/:id`; a bare `/links` would be this module claiming a word on
|
||
// a URL it does not own, and the next module to fill a slot would collide.
|
||
|
||
const test = require('node:test')
|
||
const assert = require('node:assert')
|
||
|
||
const { fakeCtx, fakeApi } = require('./_fakes')
|
||
|
||
function register(ctx = fakeCtx()) {
|
||
require('../core')._reset()
|
||
const api = fakeApi()
|
||
require('../index')(ctx, api)
|
||
return api
|
||
}
|
||
|
||
/** `[{ method, path, handlers }]` for one express router. */
|
||
function routesOf(router) {
|
||
return router.stack
|
||
.filter((layer) => layer.route)
|
||
.map((layer) => ({
|
||
path: layer.route.path,
|
||
method: Object.keys(layer.route.methods)[0].toUpperCase(),
|
||
handlers: layer.route.stack.map((s) => s.handle),
|
||
}))
|
||
}
|
||
|
||
test('the player tier serves the three identity routes, and nothing else new', () => {
|
||
const api = register()
|
||
const routes = routesOf(api.record.routes.player['/rust'])
|
||
|
||
assert.deepEqual(
|
||
routes.map((r) => `${r.method} ${r.path}`).sort(),
|
||
['DELETE /links/:steamId', 'GET /links', 'GET /servers', 'POST /link'],
|
||
)
|
||
})
|
||
|
||
test('redeeming a code is rate-limited, and by a limiter of its own', () => {
|
||
const api = register()
|
||
const post = routesOf(api.record.routes.player['/rust']).find((r) => r.method === 'POST')
|
||
|
||
// The fake's `rateLimit` hands back a pass-through carrying the options it was
|
||
// given, so the policy itself is assertable — a limiter that was quietly
|
||
// removed, or one built with core's `accountChangeLimiter` shared counter,
|
||
// both fail here.
|
||
const limiter = post.handlers.find((h) => h.options && h.options.label === 'rust-link-code')
|
||
|
||
assert.ok(limiter, 'POST /link must carry its own rate limiter (R1)')
|
||
assert.equal(limiter.options.max, 10)
|
||
assert.equal(limiter.options.windowMs, 15 * 60 * 1000)
|
||
|
||
// First in the chain: a limiter behind the validator would let an attacker
|
||
// spend the cheap half of the request unbounded.
|
||
assert.equal(post.handlers[0], limiter)
|
||
})
|
||
|
||
test('the admin.users.detail router merges the parent’s params and keeps its own segment', () => {
|
||
const api = register()
|
||
const slot = api.record.extensions.find((e) => e.slot === 'admin.users.detail')
|
||
|
||
assert.ok(slot, 'the server half of admin.users.detail must be registered')
|
||
assert.equal(slot.router.mergeParams, true)
|
||
|
||
const paths = routesOf(slot.router).map((r) => `${r.method} ${r.path}`).sort()
|
||
assert.deepEqual(paths, [
|
||
'DELETE /rust/links/:steamId',
|
||
// Phase 7 filled the same panel with what this person may do in game.
|
||
'DELETE /rust/permissions/grants/:grantId',
|
||
'GET /rust/links',
|
||
'GET /rust/permissions',
|
||
'POST /rust/permissions/grants',
|
||
])
|
||
|
||
for (const route of routesOf(slot.router)) {
|
||
assert.ok(route.path.startsWith('/rust/'), `${route.path} must live under this module's own segment`)
|
||
}
|
||
})
|