ci(core-ref): pin core at MODULE_API 1.9.0, unbreaking frozen-manifest #25
Reference in New Issue
Block a user
No description provided.
Delete Branch "ci/bump-core-ref-1.9.0"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The
frozen-manifestred on #24 was structural and predated it. This is the bump you scheduled for the moment website#178 landed — it should have ridden in #24 and did not. One file, two lines.Why it was red
ci/core-ref.jsonpinned963d734— websitemainat the Teams cutover, MODULE_API 1.6.0. That core has noceilings.js, noregisterEventTriggersand noregisterAudiences, so the module has failed to load into it since Phase 11a added the first of those calls. The job clones core at the pin and drops the module in, so a module that cannot register cannot have its routes diffed.The break is datable: the last green run was #39 (
6a276a7, Phase 10's protocol-5 ingest), which added noregister*call and so still loaded against 1.6.0. Phase 11a (#22) failed this exact job and was merged anyway, and every engagement PR since has inherited it.New pin:
52eac24— websiteedgecarrying MODULE_API 1.9.0 (registerEngagementSeeds) and the Phase 11b core fixes (website#179).routes.manifest.jsonis not regenerated, deliberatelyThe pin's own comment says "bump it, regenerate
routes.manifest.json, and commit both together" — and here there is nothing to regenerate. Phase 11b added triggers, bodies and rules and not one route. The job's own check is the evidence rather than my assertion:Committing a no-op regeneration would just be churn in the file the check exists to keep honest.
Reproduced locally, the way the job does it
The runner's Actions logs are unreadable from here, so the job's steps were run by hand against the new sha:
The
triggers: 26line is the one worth reading twice — that is the module registering against a core that actually has the API it calls, which is the whole thing that was broken.check:importsandcheck:bundlealso clean. The 527 tests are unaffected (no source change).Reverts to a
mainsha at the Phase 13 cutover, which is what the pin is for.AI-assisted: written with Claude Code.
🤖 Generated with Claude Code