wtclaude
3c179e3338
v1.0.0 installed and then died on every boot:
module "uo" failed to load — {"stage":"register","reason":"Cannot find
module './commands/guild.command'"}
`server/commands/` arrived with the Teams cutover (2d1d91e, `/guild`). The
release assembles the tarball from an include list, that list was hardcoded in
release.yml, and it was never told about the new directory — so the bundle
shipped without it and the module was dead on the operator's box.
Nothing caught it, and that is the more interesting half. Every PR check runs
against the whole repo — `frozen-manifest` even installs the module into core by
tarring the entire tree — but a release is a SUBSET of the repo, and the subset
exists nowhere except the release. The pre-publish check in release.yml only
stats the paths `module.json` declares, and a file reached by a require inside
`register()` is named in none of them, so it passed on a bundle that could not
load.
The include list stays an include list — release.yml's header makes that case
and it still holds. What changes is that it is declared ONCE, in ci/bundle.json,
with two readers instead of one:
• release.yml assembles from it (via jq) rather than from its own copy.
• server/scripts/checkBundle.js asks, in PR checks, whether it still covers
everything `server/index.js` reaches — following requires transitively and
through function bodies, which is where index.js deliberately puts them.
And the release gains a real loadability check: `checkBundle.js --bundle` walks
the ASSEMBLED tree and asserts every relative require resolves inside it. Asked
of the artifact rather than the source, so it also catches a half-failed copy or
a list naming a path that has moved.
Requiring the entry point would not have worked as a check: index.js requires
inside `register()` because require order is load-bearing (`core.init(ctx)` must
run before anything under `router/`), so requiring it evaluates one line and
reports success on a bundle missing every router it has.
Both modes were verified against the real defect — each fails with `commands`
removed and passes with it present.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WnDSWzpUjw8t8C2hghysNz
29 lines
1.5 KiB
JSON
29 lines
1.5 KiB
JSON
{
|
|
"name": "module-uo-server",
|
|
"version": "0.1.0",
|
|
"private": true,
|
|
"description": "Server half of module-uo — routers, models and the schema fragment core loads at boot",
|
|
"license": "GPL-3.0-or-later",
|
|
"main": "index.js",
|
|
"scripts": {
|
|
"test": "node --test --require ./test/_setup.js",
|
|
"check:imports": "node scripts/checkImports.js",
|
|
"check:bundle": "node scripts/checkBundle.js",
|
|
"swagger": "node scripts/swaggerFragment.js",
|
|
"check:swagger": "node scripts/swaggerFragment.js --check"
|
|
},
|
|
"engines": {
|
|
"node": ">=20"
|
|
},
|
|
"//dependencies": "The ONE runtime dependency, and it ships inside the release tarball: CI runs npm ci --omit=dev and packs server/node_modules, because an operator never builds (MODULE_SYSTEM.md 1.14). Node resolves it by walking up from modules/uo/server/. Everything else the shipped half needs arrives on ctx (MODULE_API.md 2.3) - express, express-validator, the database, the logger, the middleware and the rate-limit factory are all core-owned and handed over.",
|
|
"devDependencies": {
|
|
"express": "^4.19.2",
|
|
"express-validator": "^7.2.0",
|
|
"swagger-autogen": "^2.23.7"
|
|
},
|
|
"dependencies": {
|
|
"ws": "^8.21.0"
|
|
},
|
|
"//devDependencies": "Test-only and build-only, never shipped. test/_fakes.js builds a REAL express router - a fake Router would test the fake. swagger-autogen is the same generator core uses, pinned to the same major so the fragment and the spec it merges into come out of one tool (MODULE_API.md 2.8)."
|
|
}
|