docs(rust): the last fixes before the cutover #366

Merged
whitlocktech merged 1 commits from docs/rust-last-fixes into main 2026-10-21 06:10:05 -05:00
Member

What & why

The end walk's in-game pass ran on 2026-10-21. This adds modules/rust/PLAN_LAST_FIXES.md, the last fix list before the Rust cutover:

  • §1 The pass: builds, and the result per part. Part 1 1.1–1.6 pass. All of Part 2 passes, including 2.11 on Carbon, and 2.9/2.10 once W21 was patched on the walk site. Part 4 4.2/4.3 pass. Only 2.11 of Carbon's share was walked, per the org lead.
  • §2 What it found:
    • W21: a real bug. module-rust/server/permSync.js never pushes notices, so no reward message ever reached the game.
    • W22: PLAYER_WALK rows 2.8, 2.9 and "Before you start" expect the wrong thing.
    • W23: rbevent setowner A reads as a purchase; only … lockout locks.
    • N2: reloading RaidableBases breaks it, so change its config with a restart.
  • §3 The whole list: W1–W20 and N1 from PLAN_REDESIGNS §9.1 plus the above, grouped by repo, each with a proposed fix. W4 and W21 are the two real bugs.
  • §4 Order of building: six stages, then the release and the cutover.
  • §5 Questions Q37–Q40:
    • Q37: W19, two game modules on one site.
    • Q38: does the release wait for the second-player rows?
    • Q39: W20, the manual retry.
    • Q40: keep BetterChat on Oxide and the walk's title rules?
  • §6 The rows still owed with a second player. §7 The clean-up after the walk, including rotating the Steam Web API key.

PLAN_REDESIGNS (its status line and §9.1's "Found") and the Rust docs README point to the new file.

How it was tested

Docs only. Each row was checked against the walk's notes, the site log and the rigs' consoles. W21's cause was read in permSync.js, permissions.model.js and the sidecar's pass-through test. W23's was read in RaidableBases 3.2.2's TrySetPayLock and confirmed live: the plain form gave raid.purchased, and lockout gave raid.locked. Section references were checked: PROTOCOL §20.12 and PLAN_REDESIGNS §11.4.

Checklist

  • I have read CONTRIBUTING.md.
  • The change builds and existing tests/checks pass locally.
  • I have added or updated tests/docs where it makes sense.
  • My commits are reasonably scoped with clear messages.

AI-assisted contributions (required)

  • No AI tools were used to produce this contribution.
  • AI tools were used. Tool(s): Claude Code (Claude Opus 5.5). I have reviewed and understand
    every change, and take responsibility for it. AI-authored commits are
    marked with a Co-Authored-By / Assisted-By trailer.

License

  • I agree that my contribution is licensed under this project's license
    (GNU GPL v3.0 or later), and I have the right to contribute it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY

## What & why The end walk's in-game pass ran on 2026-10-21. This adds `modules/rust/PLAN_LAST_FIXES.md`, the last fix list before the Rust cutover: - **§1 The pass:** builds, and the result per part. Part 1 1.1–1.6 pass. All of Part 2 passes, including 2.11 on Carbon, and 2.9/2.10 once W21 was patched on the walk site. Part 4 4.2/4.3 pass. Only 2.11 of Carbon's share was walked, per the org lead. - **§2 What it found:** - **W21:** a real bug. `module-rust/server/permSync.js` never pushes `notices`, so no reward message ever reached the game. - **W22:** PLAYER_WALK rows 2.8, 2.9 and "Before you start" expect the wrong thing. - **W23:** `rbevent setowner A` reads as a purchase; only `… lockout` locks. - **N2:** reloading RaidableBases breaks it, so change its config with a restart. - **§3 The whole list:** W1–W20 and N1 from PLAN_REDESIGNS §9.1 plus the above, grouped by repo, each with a proposed fix. W4 and W21 are the two real bugs. - **§4 Order of building:** six stages, then the release and the cutover. - **§5 Questions Q37–Q40:** - Q37: W19, two game modules on one site. - Q38: does the release wait for the second-player rows? - Q39: W20, the manual retry. - Q40: keep BetterChat on Oxide and the walk's title rules? - **§6** The rows still owed with a second player. **§7** The clean-up after the walk, including rotating the Steam Web API key. PLAN_REDESIGNS (its status line and §9.1's "Found") and the Rust docs README point to the new file. ## How it was tested Docs only. Each row was checked against the walk's notes, the site log and the rigs' consoles. W21's cause was read in `permSync.js`, `permissions.model.js` and the sidecar's pass-through test. W23's was read in RaidableBases 3.2.2's `TrySetPayLock` and confirmed live: the plain form gave `raid.purchased`, and `lockout` gave `raid.locked`. Section references were checked: PROTOCOL §20.12 and PLAN_REDESIGNS §11.4. ## Checklist - [x] I have read [CONTRIBUTING.md](CONTRIBUTING.md). - [x] The change builds and existing tests/checks pass locally. - [x] I have added or updated tests/docs where it makes sense. - [x] My commits are reasonably scoped with clear messages. ## AI-assisted contributions (required) - [ ] No AI tools were used to produce this contribution. - [x] AI tools were used. Tool(s): `Claude Code (Claude Opus 5.5)`. I have reviewed and understand every change, and take responsibility for it. AI-authored commits are marked with a `Co-Authored-By` / `Assisted-By` trailer. ## License - [x] I agree that my contribution is licensed under this project's license (**GNU GPL v3.0 or later**), and I have the right to contribute it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY
wtclaude added 1 commit 2026-10-21 06:09:42 -05:00
The end walk's in-game pass ran on 2026-10-21. PLAN_LAST_FIXES.md records
what it passed and what it found, and puts every fix still open in one
list in building order: W1-W20 and N1 from the passes without a player,
plus the in-game pass's W21 (a reward's message is never pushed to the
game), W22 and W23 (walk and protocol docs that expect the wrong thing)
and N2 (reloading RaidableBases breaks it). It also asks Q37-Q40, lists
the rows still owed with a second player, and the clean-up after the
walk. PLAN_REDESIGNS and the README point to it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY
whitlocktech merged commit 27dd1f8d80 into main 2026-10-21 06:10:05 -05:00
whitlocktech deleted branch docs/rust-last-fixes 2026-10-21 06:10:05 -05:00
Sign in to join this conversation.
No description provided.