docs(installer): drop phase references that are now this build's behaviour
All checks were successful
PR Checks / rust-gates (pull_request) Successful in 2m8s
All checks were successful
PR Checks / rust-gates (pull_request) Successful in 2m8s
Five comments described the patch tier as work a later phase would do. It is this phase, so they read as stale the moment the code landed. Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -619,7 +619,7 @@ fn build_record(prior: Option<&InstallRecord>, run: &Deployment<'_>) -> InstallR
|
|||||||
files: overlay::file_records(planned),
|
files: overlay::file_records(planned),
|
||||||
}),
|
}),
|
||||||
// A `--verify` run installs no sidecar and must not erase the record of one that is
|
// A `--verify` run installs no sidecar and must not erase the record of one that is
|
||||||
// already there; the same reasoning keeps the patch section (Phase 3) and any field a
|
// already there; the same reasoning keeps the patch section and any field a
|
||||||
// newer installer wrote intact. A record that forgot a running service would make
|
// newer installer wrote intact. A record that forgot a running service would make
|
||||||
// `doctor` and `uninstall` forget it too.
|
// `doctor` and `uninstall` forget it too.
|
||||||
link: match sidecar {
|
link: match sidecar {
|
||||||
|
|||||||
@@ -145,7 +145,8 @@ mod tests {
|
|||||||
#[test]
|
#[test]
|
||||||
fn the_installers_own_files_sit_in_the_state_dir() {
|
fn the_installers_own_files_sit_in_the_state_dir() {
|
||||||
// Everything the installer owns lives together, so `uninstall` (Phase 4) has one place to
|
// Everything the installer owns lives together, so `uninstall` (Phase 4) has one place to
|
||||||
// clean and `doctor` has one place to read. The cached patch set joins them in Phase 3.
|
// clean and `doctor` has one place to read. The cached patch set and the pre-image
|
||||||
|
// copies of every patched file live there too.
|
||||||
let l = platform_layout();
|
let l = platform_layout();
|
||||||
assert_eq!(l.install_record().parent(), Some(l.state_dir.as_path()));
|
assert_eq!(l.install_record().parent(), Some(l.state_dir.as_path()));
|
||||||
assert_eq!(l.sidecar_config().parent(), Some(l.state_dir.as_path()));
|
assert_eq!(l.sidecar_config().parent(), Some(l.state_dir.as_path()));
|
||||||
|
|||||||
@@ -44,7 +44,7 @@ pub struct InstallRecord {
|
|||||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||||
pub link: Option<serde_json::Value>,
|
pub link: Option<serde_json::Value>,
|
||||||
/// The patch tier: one entry per feature actually in place, with the rung that applied each of
|
/// The patch tier: one entry per feature actually in place, with the rung that applied each of
|
||||||
/// its patches (Phase 3).
|
/// its patches.
|
||||||
///
|
///
|
||||||
/// Raw JSON for the same reason as [`InstallRecord::link`] — a record written by a newer
|
/// Raw JSON for the same reason as [`InstallRecord::link`] — a record written by a newer
|
||||||
/// installer survives a re-run here intact. Read it with [`InstallRecord::patch_records`].
|
/// installer survives a re-run here intact. Read it with [`InstallRecord::patch_records`].
|
||||||
|
|||||||
@@ -23,7 +23,7 @@ pub struct ServUoRoot {
|
|||||||
pub path: PathBuf,
|
pub path: PathBuf,
|
||||||
/// `None` when `Server/AssemblyInfo.cs` is absent or unparseable. Reported as "unknown", which
|
/// `None` when `Server/AssemblyInfo.cs` is absent or unparseable. Reported as "unknown", which
|
||||||
/// is treated exactly like any other non-57.4 answer: the base install proceeds, and the patch
|
/// is treated exactly like any other non-57.4 answer: the base install proceeds, and the patch
|
||||||
/// tier (Phase 3) takes its unsupported path.
|
/// tier takes its unsupported path.
|
||||||
pub version: Option<String>,
|
pub version: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -312,7 +312,7 @@ mod tests {
|
|||||||
#[test]
|
#[test]
|
||||||
fn an_unreadable_version_is_unknown_and_unsupported() {
|
fn an_unreadable_version_is_unknown_and_unsupported() {
|
||||||
// "Unknown" must not be optimistically treated as 57.4: an unreadable version is not
|
// "Unknown" must not be optimistically treated as 57.4: an unreadable version is not
|
||||||
// evidence of a good one, and it gates the patch tier in Phase 3.
|
// evidence of a good one, and it is what gates the patch tier.
|
||||||
let tmp = TempDir::new("rg-test-noversion").unwrap();
|
let tmp = TempDir::new("rg-test-noversion").unwrap();
|
||||||
let root = tmp.path().join("srv");
|
let root = tmp.path().join("srv");
|
||||||
fake_root(&root);
|
fake_root(&root);
|
||||||
|
|||||||
Reference in New Issue
Block a user