fix(sidecar): apply rustfmt to the protocol 3.0 cutover code #22

wtclaude · 2026-08-01T06:40:27Z

wtclaude commented

2026-08-01 06:40:27 +00:00

Why

The Release sidecar run for the 3.0 cutover merge (2301c57) failed. Its first Rust gate is cargo fmt --check, and two rustfmt violations rode in with the world.ruleset code, so the job died before it could test, build, tag, or cut a release.

Diff in sidecar/src/main.rs:262
Diff in sidecar/src/store.rs:299
##[error]Process completed with exit code 1.

What

Ran cargo fmt. Formatting only, no behavior change:

main.rs — the .upsert_ruleset(...) call fits on one line
store.rs — the upsert_ruleset signature does not, so it wraps one-param-per-line

Verification

cargo fmt --check — clean
cargo test --locked — passes (0 tests, as before)

Once this lands on main, the release workflow re-runs on the push and should get past the gate. Note the changelog for the resulting release will span both commits, which is fine.

Follow-up worth considering

link/ has no PR-check workflow — only release.yml (push to main), sonarqube.yml, and sync-project-tree.yml. That's why this was caught after merge instead of on PR #20/#21. A small pr-checks.yml running cargo fmt --check + cargo test on PRs into main/edge would stop this recurring. Happy to open that separately if wanted.

AI-assisted: written with Claude Code (Claude Opus 5).

## Why The `Release sidecar` run for the 3.0 cutover merge (`2301c57`) **failed**. Its first Rust gate is `cargo fmt --check`, and two rustfmt violations rode in with the `world.ruleset` code, so the job died before it could test, build, tag, or cut a release. ``` Diff in sidecar/src/main.rs:262 Diff in sidecar/src/store.rs:299 ##[error]Process completed with exit code 1. ``` ## What Ran `cargo fmt`. Formatting only, no behavior change: - `main.rs` — the `.upsert_ruleset(...)` call fits on one line - `store.rs` — the `upsert_ruleset` signature does not, so it wraps one-param-per-line ## Verification - `cargo fmt --check` — clean - `cargo test --locked` — passes (0 tests, as before) Once this lands on `main`, the release workflow re-runs on the push and should get past the gate. Note the changelog for the resulting release will span both commits, which is fine. ## Follow-up worth considering `link/` has no PR-check workflow — only `release.yml` (push to `main`), `sonarqube.yml`, and `sync-project-tree.yml`. That's why this was caught *after* merge instead of on PR #20/#21. A small `pr-checks.yml` running `cargo fmt --check` + `cargo test` on PRs into `main`/`edge` would stop this recurring. Happy to open that separately if wanted. --- AI-assisted: written with Claude Code (Claude Opus 5).

wtclaude added 1 commit 2026-08-01 06:40:28 +00:00

fix(sidecar): apply rustfmt to the protocol 3.0 cutover code 8c4dc0ee93

The release workflow's first gate is `cargo fmt --check`, and the 3.0
cutover merge (2301c57) landed two rustfmt violations in the
`world.ruleset` path, so the run failed before it could build or tag:

- main.rs: the `upsert_ruleset(..)` call fits on one line
- store.rs: the `upsert_ruleset` signature does not

No behavior change — formatting only.

Co-Authored-By: Claude <noreply@anthropic.com>

whitlocktech approved these changes 2026-08-01 06:41:21 +00:00

whitlocktech merged commit ef639679d1 into main

2026-08-01 06:41:47 +00:00

whitlocktech deleted branch fix/rustfmt-release

2026-08-01 06:41:48 +00:00

whitlocktech referenced this issue from a commit

2026-08-01 06:41:49 +00:00

Merge pull request 'fix(sidecar): apply rustfmt to the protocol 3.0 cutover code' (#22) from fix/rustfmt-release into main

wtclaude referenced this pull request

2026-08-01 06:44:50 +00:00

ci(link): gate pull requests into main on fmt, clippy, and test #23

Sign in to join this conversation.