wtclaude
c29ec94f46
All checks were successful
PR checks / checks (pull_request) Successful in 1m25s
D4 asked for screenshots of the review stack rather than placeholders. Seventeen
of them: eleven of the site in a browser, six of the app on a phone, all from one
demo deployment wired to a running ServUO shard over a real sidecar, captured on
one day (D42).
The deployment is branded "Runic Gateway Demo" rather than a real community (D43),
and the captures sit beside the claims they support — the homepage, /features/, and
five of the administration pages phase 7 could describe but not show (D44).
The rig is committed rather than remembered (D45):
scripts/seedDemo.mjs content, by driving the site's own API — never SQL,
because a row the product could not have produced is
a screenshot of a product that does not exist
src/data/screens.mjs every capture: route, viewport, scroll, alt, caption
scripts/captureScreens.mjs npm run screens:capture
scripts/checkScreens.mjs the ninth check script, in CI
Shard-side dressing is servuo-plugins' scaffolding (D46), never deployed.
The rig found five things nothing else had. One is fixed upstream — a fresh
module-uo install pinned wire protocol 3 against a sidecar speaking 4, released as
v1.0.2, which this repo's own facts check then caught in platform.json. Four are
raised as product observations and worked around in the rig: a renamed guild
member never reaches the site, a guild deleted while the shard is down is a ghost
row forever, "Houses in danger" cannot show a house that was already collapsing,
and the app's news list prints raw ISO timestamps.
Players online reads 0. Logging a character in needs a UO client driven by hand,
and that is where this stopped — PLAN.md §10 says exactly why, and how to retake
the two frames that would change.
Co-Authored-By: Claude <noreply@anthropic.com>
82 lines
2.6 KiB
Plaintext
82 lines
2.6 KiB
Plaintext
---
|
|
import { screenById, WEB, PHONE } from '../data/screens.mjs';
|
|
|
|
/**
|
|
* One screenshot, as a figure with its caption. PLAN.md §13 phase 9, D4 / D44.
|
|
*
|
|
* -----------------------------------------------------------------------------------------
|
|
* WHY THE PAGE PASSES AN ID AND NOTHING ELSE
|
|
* -----------------------------------------------------------------------------------------
|
|
* A marketing page and a documentation page show the same administration screen for
|
|
* different reasons, and the thing they must not do is describe it differently. The alt
|
|
* text and the caption therefore live with the capture in `screens.mjs`, next to the route
|
|
* they came from, and a page asks for `admin-shard` rather than restating what is in it.
|
|
*
|
|
* It also means a re-capture cannot silently invalidate a caption: the sentence and the
|
|
* frame it describes are edited in the same file.
|
|
*
|
|
* -----------------------------------------------------------------------------------------
|
|
* WHY IT FAILS THE BUILD ON AN UNKNOWN ID
|
|
* -----------------------------------------------------------------------------------------
|
|
* The alternative is a page that renders a broken image, which looks like a deployment
|
|
* problem rather than a typo and survives review. `checkScreens.mjs` covers the other
|
|
* direction — a declared screen whose file is missing — so between them a screenshot is
|
|
* either complete or the build stops.
|
|
*/
|
|
interface Props {
|
|
/** An `id` from `src/data/screens.mjs`. */
|
|
id: string;
|
|
/** Suppress the caption where the surrounding prose already says it. */
|
|
bare?: boolean;
|
|
}
|
|
|
|
const { id, bare = false } = Astro.props;
|
|
|
|
const shot = screenById(id);
|
|
|
|
if (!shot) {
|
|
throw new Error(`Screenshot "${id}" is not declared in src/data/screens.mjs`);
|
|
}
|
|
|
|
const src = `/screens/${shot.id}.webp`;
|
|
|
|
// Intrinsic size comes from the family rather than the entry: every capture in a family is
|
|
// taken at one geometry (see screens.mjs), and `checkScreens.mjs` asserts the files really
|
|
// are that size, so these attributes cannot drift from the pixels.
|
|
const { width, height } = shot.family === 'web' ? WEB : PHONE;
|
|
---
|
|
|
|
<figure class="shot">
|
|
<img
|
|
src={src}
|
|
alt={shot.alt}
|
|
width={width}
|
|
height={height}
|
|
loading="lazy"
|
|
decoding="async"
|
|
/>
|
|
{!bare && <figcaption>{shot.caption}</figcaption>}
|
|
</figure>
|
|
|
|
<style>
|
|
.shot {
|
|
margin: 2rem 0;
|
|
}
|
|
|
|
.shot img {
|
|
display: block;
|
|
width: 100%;
|
|
height: auto;
|
|
border: 1px solid var(--line);
|
|
border-radius: var(--radius-card);
|
|
box-shadow: var(--shadow-card);
|
|
}
|
|
|
|
.shot figcaption {
|
|
margin: 0.85rem 0 0;
|
|
color: var(--dim);
|
|
font-size: 0.9rem;
|
|
line-height: 1.5;
|
|
}
|
|
</style>
|