chore(quality): resolve SonarQube code smells across website

Clears the 124 CODE_SMELL findings from the SonarQube scan (server, client,
and bot). All changes are behaviour-preserving refactors — no route, protocol,
schema, or config changes — verified against the full server (381) and client
(43) test suites plus a clean client build.

By rule:
- S3776 (20, cognitive complexity): extract helpers/handlers so each function
  drops under the threshold — shard model upsert builders, page/wiki update,
  block validation, notification stream mapping (dispatch table), SSO mobile
  login, shard ingest deps, uo-link socket backfill/connect, the bot slash-
  command dispatchers + discord manager, and the Shard/UserDetail/HeroEditor/
  CharacterStats React components.
- S4624 (34, nested template literals): pull inner templates into locals /
  a withQs() helper; rewrite shardEvents.describe() as a formatter table.
- S3358 (35, nested ternaries): lift to if/else vars, lookup maps, small
  components, or guarded JSX expressions.
- S6479 (12, array-index React keys): key by stable content instead of index
  (two in-editor lists left as-is; index matches their by-index edit model).
- S6353 (6): [0-9]/[^0-9] -> \d/\D.  S125 (5): reword state-shape comments that
  parsed as code.  S3800/S3782 (botScore): JSDoc-type PATH_WEIGHTS tuples.
- S6481 (2): memoize Auth/Site context values (and SiteContext brand).
- S4144: dedupe HeroEditor upload handler into useImageUpload().
- S1126 (2), S6035, S5869 (redundant A-Z under /i), S5843 (town-name regex ->
  prefix list): assorted one-liners.

Co-Authored-By: Claude <noreply@anthropic.com>

server/src/model/shardState/shardState.model.js

@@ -8,6 +8,17 @@ const db = require('./shardState.db')
 
 const MAX_ECONOMY = 1000
 
+// Small coercion helpers, kept out of the upsert builders below so those stay
+// flat (each inline `?? null` / ternary otherwise adds to cognitive complexity).
+const orNull = (v) => v ?? null
+const toDate = (v) => (v ? new Date(v) : null)
+// Owner is an actor object (or null for an abandoned house); flatten to columns.
+const ownerFields = (owner) => ({
+  owner_serial: orNull(owner?.serial),
+  owner_acct: orNull(owner?.acct),
+  owner_name: orNull(owner?.name),
+})
+
 // Map a camelCase online descriptor to DB columns, dropping undefined keys so a
 // partial refresh only touches the fields it carries.
 function onlineFields(data) {
@@ -180,23 +191,20 @@ async function listHousesForAccounts(accounts) {
 // actor object (or null for an abandoned house).
 async function upsertHouseRegistry(data) {
   if (!data || !data.serial) return
-  const owner = data.owner || null
   const fields = {
-    name: data.name ?? null,
-    owner_serial: owner ? owner.serial ?? null : null,
-    owner_acct: owner ? owner.acct ?? null : null,
-    owner_name: owner ? owner.name ?? null : null,
-    co_owners: data.coOwners ?? null,
-    friends: data.friends ?? null,
-    price: data.price ?? null,
-    decay: data.decay ?? null,
-    region: data.region ?? null,
-    map: data.map ?? null,
-    x: data.x ?? null,
-    y: data.y ?? null,
-    z: data.z ?? null,
-    built_on: data.builtOn ? new Date(data.builtOn) : null,
-    last_refreshed: data.lastRefreshed ? new Date(data.lastRefreshed) : null,
+    name: orNull(data.name),
+    ...ownerFields(data.owner || null),
+    co_owners: orNull(data.coOwners),
+    friends: orNull(data.friends),
+    price: orNull(data.price),
+    decay: orNull(data.decay),
+    region: orNull(data.region),
+    map: orNull(data.map),
+    x: orNull(data.x),
+    y: orNull(data.y),
+    z: orNull(data.z),
+    built_on: toDate(data.builtOn),
+    last_refreshed: toDate(data.lastRefreshed),
     in_registry: 1,
   }
   await db.upsertHouse(data.serial, fields)
@@ -222,15 +230,15 @@ async function listOnlineForAccounts(accounts) {
 async function upsertChamp(ev) {
   if (!ev || !ev.serial) return
   await db.upsertChamp(ev.serial, {
-    category: ev.category ?? null,
-    type: ev.type ?? null,
-    name: ev.name ?? null,
-    status: ev.status ?? null,
+    category: orNull(ev.category),
+    type: orNull(ev.type),
+    name: orNull(ev.name),
+    status: orNull(ev.status),
     active: ev.active ? 1 : 0,
-    map: ev.map ?? null,
-    x: ev.x ?? null,
-    y: ev.y ?? null,
-    z: ev.z ?? null,
+    map: orNull(ev.map),
+    x: orNull(ev.x),
+    y: orNull(ev.y),
+    z: orNull(ev.z),
     boss_up: ev.bossUp ? 1 : 0,
     payload: JSON.stringify(ev),
     t: Number.isFinite(ev.t) ? ev.t : null,
@@ -280,18 +288,18 @@ async function upsertPage(ev) {
   if (!pageId) return
   const sender = ev.sender || {}
   await db.upsertPage(pageId, {
-    type: ev.type ?? null,
-    sender_name: sender.name ?? null,
-    sender_acct: sender.acct ?? null,
-    web_id: sender.webId ?? null,
-    message: ev.message ?? null,
-    map: ev.map ?? null,
-    x: ev.x ?? null,
-    y: ev.y ?? null,
-    z: ev.z ?? null,
+    type: orNull(ev.type),
+    sender_name: orNull(sender.name),
+    sender_acct: orNull(sender.acct),
+    web_id: orNull(sender.webId),
+    message: orNull(ev.message),
+    map: orNull(ev.map),
+    x: orNull(ev.x),
+    y: orNull(ev.y),
+    z: orNull(ev.z),
     sent_ms: Number.isFinite(ev.sentMs) ? ev.sentMs : null,
     handled: ev.handled ? 1 : 0,
-    handler: ev.handler ?? null,
+    handler: orNull(ev.handler),
     payload: JSON.stringify(ev),
   })
 }
@@ -406,19 +414,19 @@ async function listGuildsLedForAccounts(accounts) {
 async function upsertGovernor(ev) {
   if (!ev || !ev.city) return
   await recordGovernorTransition(ev)
-  const gov = ev.governor || null
-  const elect = ev.governorElect || null
+  const gov = ev.governor
+  const elect = ev.governorElect
   await db.upsertGovernor(ev.city, {
-    governor_serial: gov ? gov.serial ?? null : null,
-    governor_name: gov ? gov.name ?? null : null,
-    governor_acct: gov ? gov.acct ?? null : null,
-    governor_web_id: gov ? gov.webId ?? null : null,
-    elect_serial: elect ? elect.serial ?? null : null,
-    elect_name: elect ? elect.name ?? null : null,
-    elect_acct: elect ? elect.acct ?? null : null,
-    election_phase: ev.electionPhase ?? null,
-    candidates: ev.candidates ?? null,
-    auto_pick_at: ev.autoPickAt ? new Date(ev.autoPickAt) : null,
+    governor_serial: orNull(gov?.serial),
+    governor_name: orNull(gov?.name),
+    governor_acct: orNull(gov?.acct),
+    governor_web_id: orNull(gov?.webId),
+    elect_serial: orNull(elect?.serial),
+    elect_name: orNull(elect?.name),
+    elect_acct: orNull(elect?.acct),
+    election_phase: orNull(ev.electionPhase),
+    candidates: orNull(ev.candidates),
+    auto_pick_at: toDate(ev.autoPickAt),
     payload: JSON.stringify(ev),
     t: Number.isFinite(ev.t) ? ev.t : null,
   })