feat(engagement): the admin ceiling and core's news.post emitter (Phase 11a)
All checks were successful
PR Checks / client-build (pull_request) Successful in 26s
PR Checks / bot-tests (pull_request) Successful in 28s
PR Checks / server-tests (pull_request) Successful in 13m3s

Core's half of ENGAGEMENT.md Phase 11a: the two decisions the org lead settled
before any code that land in core rather than in module-uo. Pairs with
Module-uo#22 and docs#194.

## Decision 1 -- a seventh ceiling, `admin`, as a child of `staff`

Phase 11's operator-facing triggers (uo.audit.staff_action, uo.economy.milestone,
uo.world.saved) are described as admin-audience everywhere, and the narrowest
value the lattice had was `staff` -- which ceilings.js defines as admin, editor
AND moderator. Ceilinging them there would have let an operator save a rule that
mails the staff audit digest to every moderator in it.

`admin` is the ONLY genuine refinement in the tree -- every admin is staff, which
is exactly the containment every other pair of branches lacks -- so it is a child
rather than a seventh leaf, and permits/meet/meetAll needed no change beyond the
new PARENT entry.

**The one non-obvious consequence, and the reason for ROLE_CEILINGS.**
notificationChannelPrefs' `visibleTo` asked `item.ceiling !== 'staff'`. That was
correct while `staff` was the only role-gated value, and the day `admin` arrived
it would have silently published every admin-ceilinged id -- the staff audit
digest, the economy thresholds -- to every player's preferences screen by name.
It now reads a TABLE (`ceilings.reachableBy`), so a ceiling added without an entry
fails closed instead. An EDITOR is the viewer that tells the two rules apart, and
the new tests use one.

MODULE_API_VERSION -> 1.8.0 on both halves. Additive: every declaration valid
under 1.7.0 is valid now and no stored value changes.

## Decision 5 -- 7.1 Q9: news.post gets an emitter, and it REPLACES the tickle

`news.post` has been a declared payload contract with no caller since Phase 2, so
a rule naming it could never fire. utils/newsNotify.js is the caller;
announceIfNewlyPublished now calls it instead of pushDispatch.publish, gated on
the same enqueueIfNeeded job id -- the single "newly published news" transition
signal, not re-derived.

**News push therefore stops on upgrade** until an operator enables the seeded
rule. That is the org lead's decision, taken over keeping the raw call beside the
emit "for one release": an exception with a deadline nobody owns, which Phase 6
already refused for Teams. The Rules screen gains a second migration notice
naming news, and Phase 13's release note carries it as an upgrade step.

**The seed needed its own one-shot key, and this is the trap worth recording.**
`engagement_team_rules_seeded` is already stamped on every deployment that has
booted since Phase 6, and the guard reads its presence -- so appending news to
RULES would have seeded it on fresh installs only, and on exactly the upgrades
that lose their raw push, never. One key per seed GROUP is now the rule;
seedGroup() is the shared implementation and seedCoreRules() is what boot calls.

Also fixes news.post's `postUrl` example, which named `/news/<slug>` -- a path
App.jsx does not mount. An example is what the template editor previews and
test-sends with, so a wrong one is a preview that looks right and a mail that is
not. It is `/site/news`, the list, which is what the Discord and town-crier
announcements have always linked.

1550 tests pass (16 new), 327 client tests pass, client builds, check:modules
clean -- core still names no module identifier with module-uo now registering 24
UO-named triggers.

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
2026-08-31 20:33:02 -05:00
parent 49a61fdafa
commit 1d4cd4adae
17 changed files with 669 additions and 56 deletions

View File

@@ -35,6 +35,9 @@ after(() => db.close())
const USER = 7
const PLAYER = { id: USER, role: 'player' }
const ADMIN = { id: USER, role: 'admin' }
// Phase 11 added the `admin` ceiling beneath `staff`, so the interesting viewer
// is no longer "player vs staff" but the one INSIDE `staff` and outside `admin`.
const EDITOR = { id: USER, role: 'editor' }
// ── In-memory stand-ins for the two tables ─────────────────────────────────
//
@@ -338,6 +341,60 @@ test('a staff-ceilinged trigger is not offered to a player, and is to staff', as
assert.equal(prefRows.size, 0)
})
// **The Phase 11 ceiling, and the reason `visibleTo` stopped asking about `staff`
// by name.** Its rule used to be `ceiling !== 'staff'`, which was correct while
// `staff` was the only role-gated value and would have silently published every
// admin-ceilinged id to every player the day `admin` arrived. An editor is the
// viewer that tells the two apart: inside `staff`, outside `admin`.
test('an admin-ceilinged trigger is hidden from a player AND from an editor', async () => {
const api = registries.stage('uo')
api.registerEventTriggers([{
id: 'uo.audit.staff_action',
label: 'A staff member acted in game',
ceiling: 'admin',
audience: 'admin',
variables: [{ name: 'action', type: 'string', required: true, example: 'set' }],
}])
registries.apply(api.staged)
const asPlayer = await prefs.getForUser(USER, PLAYER)
assert.equal(item(asPlayer, 'uo.audit.staff_action'), undefined, 'a player is not told it exists')
// The one an `!== staff` test would have got wrong: an editor IS staff, and a
// digest of what staff did in game is not for them.
const asEditor = await prefs.getForUser(USER, EDITOR)
assert.equal(item(asEditor, 'uo.audit.staff_action'), undefined, 'an editor is not told either')
const asAdmin = await prefs.getForUser(USER, ADMIN)
assert.ok(item(asAdmin, 'uo.audit.staff_action'), 'an admin is')
// A gate, not a display rule: an editor who knows the id still cannot store a
// preference for it.
await notifCtrl.putChannelPrefs(
{ user: EDITOR, body: { prefs: [{ id: 'uo.audit.staff_action', channel: 'email', mode: 'instant' }] } },
mockRes(),
)
assert.equal(prefRows.size, 0)
})
// The counterpart, so the generalisation did not quietly hide more than it should.
test('a staff-ceilinged trigger is still offered to an editor', async () => {
const api = registries.stage('uo')
api.registerEventTriggers([{
id: 'uo.page.new',
label: 'A player opened a help page',
ceiling: 'staff',
audience: 'staff',
variables: [{ name: 'pageType', type: 'string', required: true, example: 'Stuck' }],
}])
registries.apply(api.staged)
const asEditor = await prefs.getForUser(USER, EDITOR)
assert.ok(item(asEditor, 'uo.page.new'), 'an editor is inside the staff ceiling')
assert.equal(item(await prefs.getForUser(USER, PLAYER), 'uo.page.new'), undefined)
})
// ── The channel registry itself ────────────────────────────────────────────
test('the registry refuses a channel that under-declares', async () => {