refactor(server): dedupe shard-state shaping, upsert builder, and config DB models

Address the SonarQube copy-paste findings that reflect real duplication (as
opposed to the intentional cross-package / admin-player mirror copies, which
are by-design and left as-is):

- shardState.model.js: listOnline() re-inlined the exact field mapping that
  shapeOnline() already provides (used by listOnlineLinked). Collapse it onto
  shapeOnline so the two can no longer drift.
- shardState.db.js: extract a single upsertRow(table, pkCol, pk, fields,
  {coalesce}) builder for the five near-identical INSERT ... ON DUPLICATE KEY
  UPDATE bodies (online/houses/champs/guilds/governors). shard_online keeps its
  COALESCE-on-NULL semantics via the coalesce flag.
- botConfig/emailConfig/uoLinkConfig .db.js: generate get()/upsert() from a
  shared singletonConfigDb(table, cols) factory instead of three byte-identical
  copies.

Behavior unchanged; full server suite (381 tests) passes.

Co-Authored-By: Claude <noreply@anthropic.com>

server/src/model/shardState/shardState.db.js

@@ -1,26 +1,37 @@
 const { query } = require('../../utils/db')
 
+// Shared upsert builder for the shard-state tables. Each is keyed on a single
+// primary column (`pkCol` = pk); `fields` carries only the columns the model
+// wants to write, so a partial refresh touches nothing else. `coalesce` keeps
+// the prior column value when the incoming one is NULL (used by shard_online so a
+// vitals frame that omits acct/name doesn't blank what mob.login set); otherwise
+// the incoming value wins (VALUES()).
+function upsertRow(table, pkCol, pk, fields, { coalesce = false } = {}) {
+  const cols = Object.keys(fields)
+  const allCols = [pkCol, ...cols]
+  const insertCols = allCols.map((c) => `\`${c}\``).join(', ')
+  const placeholders = allCols.map(() => '?').join(', ')
+  const rhs = coalesce
+    ? (c) => `\`${c}\` = COALESCE(VALUES(\`${c}\`), \`${c}\`)`
+    : (c) => `\`${c}\` = VALUES(\`${c}\`)`
+  const updates = cols.map(rhs).join(', ')
+  return query(
+    `INSERT INTO ${table} (${insertCols}) VALUES (${placeholders})
+     ON DUPLICATE KEY UPDATE ${updates}`,
+    [pk, ...cols.map((c) => fields[c])],
+  )
+}
+
 // ── Online players ─────────────────────────────────────────────────────────
 const ONLINE_COLS =
   'serial, name, acct, web_id, map, x, y, z, hits, hits_max, mana, mana_max, stam, stam_max, str, dex, `int`, updated_at'
 
 // Upsert one online player. `fields` already prepared by the model (only the
 // columns it wants to write); serial is required and is the primary key.
-async function upsertOnline(serial, fields) {
-  const cols = Object.keys(fields)
-  const allCols = ['serial', ...cols]
-  const insertCols = allCols.map((c) => `\`${c}\``).join(', ')
-  const placeholders = allCols.map(() => '?').join(', ')
-  // Never overwrite an existing column with NULL on refresh (a char.vitals frame
-  // that omits acct/name shouldn't blank what mob.login set) — COALESCE keeps the
-  // prior value when the incoming one is NULL.
-  const updates = cols.map((c) => `\`${c}\` = COALESCE(VALUES(\`${c}\`), \`${c}\`)`).join(', ')
-  await query(
-    `INSERT INTO shard_online (${insertCols}) VALUES (${placeholders})
-     ON DUPLICATE KEY UPDATE ${updates}`,
-    [serial, ...cols.map((c) => fields[c])],
-  )
-}
+// COALESCE variant: a char.vitals frame that omits acct/name must not blank what
+// mob.login set, so an incoming NULL keeps the prior column value.
+const upsertOnline = (serial, fields) =>
+  upsertRow('shard_online', 'serial', serial, fields, { coalesce: true })
 
 const removeOnline = (serial) => query('DELETE FROM shard_online WHERE serial = ?', [serial])
 const clearOnline = () => query('DELETE FROM shard_online')
@@ -89,18 +100,7 @@ async function latestEconomy() {
 const HOUSE_COLS =
   'serial, stage, map, x, y, z, region, name, owner_serial, owner_acct, built_on, last_refreshed, is_idoc, updated_at'
 
-async function upsertHouse(serial, fields) {
-  const cols = Object.keys(fields)
-  const allCols = ['serial', ...cols]
-  const insertCols = allCols.map((c) => `\`${c}\``).join(', ')
-  const placeholders = allCols.map(() => '?').join(', ')
-  const updates = cols.map((c) => `\`${c}\` = VALUES(\`${c}\`)`).join(', ')
-  await query(
-    `INSERT INTO shard_houses (${insertCols}) VALUES (${placeholders})
-     ON DUPLICATE KEY UPDATE ${updates}`,
-    [serial, ...cols.map((c) => fields[c])],
-  )
-}
+const upsertHouse = (serial, fields) => upsertRow('shard_houses', 'serial', serial, fields)
 
 const listIdocHouses = () =>
   query(`SELECT ${HOUSE_COLS} FROM shard_houses WHERE is_idoc = 1 ORDER BY updated_at DESC`)
@@ -132,18 +132,7 @@ const listRegistryHouses = () =>
 const CHAMP_COLS =
   'serial, category, type, name, status, active, map, x, y, z, boss_up, payload, t, updated_at'
 
-async function upsertChamp(serial, fields) {
-  const cols = Object.keys(fields)
-  const allCols = ['serial', ...cols]
-  const insertCols = allCols.map((c) => `\`${c}\``).join(', ')
-  const placeholders = allCols.map(() => '?').join(', ')
-  const updates = cols.map((c) => `\`${c}\` = VALUES(\`${c}\`)`).join(', ')
-  await query(
-    `INSERT INTO shard_champs (${insertCols}) VALUES (${placeholders})
-     ON DUPLICATE KEY UPDATE ${updates}`,
-    [serial, ...cols.map((c) => fields[c])],
-  )
-}
+const upsertChamp = (serial, fields) => upsertRow('shard_champs', 'serial', serial, fields)
 
 const removeChamp = (serial) => query('DELETE FROM shard_champs WHERE serial = ?', [serial])
 const clearChamps = () => query('DELETE FROM shard_champs')
@@ -176,18 +165,7 @@ const listPages = () => query(`SELECT ${PAGE_COLS} FROM shard_pages ORDER BY sen
 const GUILD_COLS =
   'id, name, abbr, members, online, alliance, leader_serial, leader_name, leader_acct, leader_web_id, payload, t, updated_at'
 
-async function upsertGuild(id, fields) {
-  const cols = Object.keys(fields)
-  const allCols = ['id', ...cols]
-  const insertCols = allCols.map((c) => `\`${c}\``).join(', ')
-  const placeholders = allCols.map(() => '?').join(', ')
-  const updates = cols.map((c) => `\`${c}\` = VALUES(\`${c}\`)`).join(', ')
-  await query(
-    `INSERT INTO shard_guilds (${insertCols}) VALUES (${placeholders})
-     ON DUPLICATE KEY UPDATE ${updates}`,
-    [id, ...cols.map((c) => fields[c])],
-  )
-}
+const upsertGuild = (id, fields) => upsertRow('shard_guilds', 'id', id, fields)
 
 const removeGuild = (id) => query('DELETE FROM shard_guilds WHERE id = ?', [id])
 const clearGuilds = () => query('DELETE FROM shard_guilds')
@@ -219,18 +197,7 @@ const listGuildsLedByAccounts = (accounts) =>
 const GOV_COLS =
   'city, governor_serial, governor_name, governor_acct, governor_web_id, elect_serial, elect_name, elect_acct, election_phase, candidates, auto_pick_at, payload, t, updated_at'
 
-async function upsertGovernor(city, fields) {
-  const cols = Object.keys(fields)
-  const allCols = ['city', ...cols]
-  const insertCols = allCols.map((c) => `\`${c}\``).join(', ')
-  const placeholders = allCols.map(() => '?').join(', ')
-  const updates = cols.map((c) => `\`${c}\` = VALUES(\`${c}\`)`).join(', ')
-  await query(
-    `INSERT INTO shard_governors (${insertCols}) VALUES (${placeholders})
-     ON DUPLICATE KEY UPDATE ${updates}`,
-    [city, ...cols.map((c) => fields[c])],
-  )
-}
+const upsertGovernor = (city, fields) => upsertRow('shard_governors', 'city', city, fields)
 
 const listGovernors = () => query(`SELECT ${GOV_COLS} FROM shard_governors ORDER BY city ASC`)