feat(events): enablement, per-run caps and mayInvoke (Phase 6)
Two new tables — event_action_settings (the deployment switchboard) and event_run_budget (what a run has spent and the most it may) — plus verified_at and verified_by on event_versions. The whole authorisation decision moves behind one function, events/authorize.js: role, enablement, cap, and the shard's own switch named as the layer core deliberately does not duplicate. Three routes, none moved: GET/PUT /admin/events/actions (admin in both directions) and POST /admin/events/:id/verify (admin, editor — a dry run dispatches nothing). Four decisions, settled by the org lead 2026-09-03: - The default-off line falls between inspect and change, not between notify and inspect. Read literally, §K shipped core.wait disabled. The same line is the role floor. - The tightest cap wins where two actions spend one dimension, pinned into the run at creation with the action it came from. - A refusal follows the step's on_failure and takes health to degraded — its own status and its own log kind, because a refusal is not an outage. - The verify gate is enforced for scheduled starts only: a human pressing Start now is the review the gate exists to require. Derived and flagged for review: a dry run fails rather than warns on a disabled action or an over-cap plan, and the unattended path does not re-check the starter's role. +111 tests (1921/1847/73/1 — the one failure pre-existing and environmental), including a 403 walk over the real router and two concurrent spends against one cap on a real MariaDB. The live walk found two defects, both fixed here: the run console route dropped the budget it was handed, and the role refusal used a plural verb over a one-item list. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T6t8mrAWhZU5vnyYgZTMtL
This commit is contained in:
@@ -32,6 +32,8 @@ const runs = require('../../../model/events/eventRuns.model')
|
||||
const controls = require('../../../model/events/eventRunControls.model')
|
||||
const logDb = require('../../../model/events/eventRunLog.db')
|
||||
const activity = require('../../../model/activity/activity.model')
|
||||
const settingsDb = require('../../../model/events/eventActionSettings.db')
|
||||
const authorize = require('../../../events/authorize')
|
||||
|
||||
const asId = (raw) => {
|
||||
const n = Number(raw)
|
||||
@@ -57,6 +59,10 @@ const shapeDefinition = (d) => ({
|
||||
state: d.state,
|
||||
currentVersionId: d.current_version_id,
|
||||
currentVersion: d.current_version,
|
||||
// §K's gate, rendered where it can still be acted on. `null` on a draft --
|
||||
// there is no version to have verified -- and a date once a dry run has passed
|
||||
// against the published one.
|
||||
currentVersionVerifiedAt: d.current_version_verified_at || null,
|
||||
seriesId: d.series_id,
|
||||
seriesName: d.series_name,
|
||||
seriesOrder: d.series_order,
|
||||
@@ -289,6 +295,11 @@ exports.getRun = async (req, res) => {
|
||||
// `eventRuns.model.detail` for why the sentence is built here and not in
|
||||
// the browser.
|
||||
gates: found.gates,
|
||||
// The caps this run was given and what it has spent (Phase 6). Copied into
|
||||
// the run when it was created, so it answers "what was THIS run allowed"
|
||||
// rather than "what is allowed now" — which is the question that survives
|
||||
// an admin moving a switch tomorrow.
|
||||
budget: found.budget,
|
||||
})
|
||||
}
|
||||
|
||||
@@ -342,7 +353,7 @@ exports.listVersions = async (req, res) => {
|
||||
|
||||
/** POST /api/v1/admin/events */
|
||||
exports.create = async (req, res) => {
|
||||
const result = await definitions.create(req.body, req.user.id)
|
||||
const result = await definitions.create(req.body, req.user.id, { role: req.user.role })
|
||||
if (!result.ok) return res.status(result.status || 400).json({ errors: result.errors })
|
||||
await activity.log({
|
||||
req,
|
||||
@@ -356,7 +367,7 @@ exports.create = async (req, res) => {
|
||||
exports.update = async (req, res) => {
|
||||
const id = asId(req.params.id)
|
||||
if (!id) return res.status(400).json({ error: 'bad event id' })
|
||||
const result = await definitions.save(id, req.body, req.user.id)
|
||||
const result = await definitions.save(id, req.body, req.user.id, { role: req.user.role })
|
||||
if (!result.ok) return res.status(result.status || 400).json({ errors: result.errors })
|
||||
await activity.log({
|
||||
req,
|
||||
@@ -388,6 +399,139 @@ exports.publish = async (req, res) => {
|
||||
})
|
||||
}
|
||||
|
||||
/**
|
||||
* POST /api/v1/admin/events/:id/verify — the dry run.
|
||||
*
|
||||
* `admin, editor` rather than `admin` (§ API surface): a dry run dispatches
|
||||
* nothing and changes nothing, and the author who wrote the definition is
|
||||
* exactly who should be able to price it against the caps before asking an
|
||||
* admin to publish it.
|
||||
*
|
||||
* **A report with findings is a 200, not a 400.** The request succeeded; the
|
||||
* plan has problems. Answering 4xx would make "this event asks for 45 creatures
|
||||
* and you allow 30" indistinguishable to the client from "you sent a bad event
|
||||
* id", and the whole value of the screen is rendering the findings.
|
||||
*/
|
||||
exports.verify = async (req, res) => {
|
||||
const id = asId(req.params.id)
|
||||
if (!id) return res.status(400).json({ error: 'bad event id' })
|
||||
const result = await definitions.verify(id, req.user)
|
||||
if (!result.ok) return res.status(result.status || 400).json({ errors: result.errors })
|
||||
await activity.log({
|
||||
req,
|
||||
action: 'event.definition.verified',
|
||||
detail: {
|
||||
id,
|
||||
target: result.target,
|
||||
versionId: result.versionId,
|
||||
passed: result.report.ok,
|
||||
findings: result.report.findings.length,
|
||||
},
|
||||
})
|
||||
return res.json({
|
||||
target: result.target,
|
||||
versionId: result.versionId,
|
||||
version: result.version,
|
||||
recorded: result.recorded,
|
||||
report: result.report,
|
||||
})
|
||||
}
|
||||
|
||||
/**
|
||||
* GET /api/v1/admin/events/actions — the deployment's switchboard.
|
||||
*
|
||||
* Every registered action, each with the deployment's stored opinion of it or,
|
||||
* where there is none, **the default its risk class implies**. The default is
|
||||
* computed by `authorize.isEnabled` rather than here, because a screen that
|
||||
* worked out the posture for itself would be a second copy of the posture, and
|
||||
* the copy that drifts is always the one on the screen.
|
||||
*
|
||||
* `configured` says whether a row exists, which the client needs to tell "an
|
||||
* admin turned this on" from "this has always been on" — the same fact, arrived
|
||||
* at two ways, and only one of them is a decision somebody made.
|
||||
*/
|
||||
exports.actions = async (_req, res) => {
|
||||
const all = registries.allEventActions()
|
||||
const stored = await settingsDb.byIds(all.map((a) => a.id))
|
||||
return res.json({
|
||||
actions: all.map((a) => {
|
||||
const row = stored.get(a.id) || null
|
||||
const full = registries.eventAction(a.id)
|
||||
return {
|
||||
...a,
|
||||
enabled: authorize.isEnabled(full, row),
|
||||
configured: Boolean(row),
|
||||
changesWorld: authorize.changesWorld(full),
|
||||
// The dimensions this action can spend, so the screen can offer a cap
|
||||
// box per dimension. Discovered by pricing the action's own declared
|
||||
// examples until §F's `registerEventBudgets` lands in Phase 7 — see
|
||||
// `authorize.dimensionsOf`.
|
||||
dimensions: authorize.dimensionsOf(full),
|
||||
caps: row?.caps || {},
|
||||
updatedAt: row?.updated_at || null,
|
||||
updatedBy: row?.updated_by_username || null,
|
||||
}
|
||||
}),
|
||||
// The rule the screen explains to the operator, served rather than written
|
||||
// into the client twice.
|
||||
worldChangingRisks: authorize.WORLD_CHANGING,
|
||||
})
|
||||
}
|
||||
|
||||
/**
|
||||
* PUT /api/v1/admin/events/actions — set one action's switch and caps.
|
||||
*
|
||||
* One action per request rather than the whole board: the board is rendered from
|
||||
* the registry and a whole-board PUT would have to say what an action MISSING
|
||||
* from the body means. On a screen listing what is registered right now, that is
|
||||
* "a module booted between the GET and the PUT", and answering it by writing a
|
||||
* default over an admin's stored choice is the kind of quiet data loss a sparse
|
||||
* write does not have.
|
||||
*/
|
||||
exports.saveAction = async (req, res) => {
|
||||
const actionId = String(req.body?.actionId || '')
|
||||
const action = registries.eventAction(actionId)
|
||||
if (!action) return res.status(404).json({ error: 'no module registers that action' })
|
||||
|
||||
if (typeof req.body?.enabled !== 'boolean') {
|
||||
return res.status(400).json({ error: 'enabled must be true or false' })
|
||||
}
|
||||
|
||||
// Caps are validated against the dimensions this action can actually spend.
|
||||
// A cap on a dimension it never names is not a harmless extra row — it is a
|
||||
// number an operator believes is protecting them, on a screen that would
|
||||
// render it back to them forever, bounding nothing.
|
||||
const known = new Set(authorize.dimensionsOf(action))
|
||||
const caps = {}
|
||||
for (const [dimension, raw] of Object.entries(req.body?.caps || {})) {
|
||||
if (raw === null || raw === '') continue
|
||||
if (!known.has(dimension)) {
|
||||
return res.status(400).json({ error: `"${action.id}" does not spend "${dimension}"` })
|
||||
}
|
||||
const n = Number(raw)
|
||||
if (!Number.isInteger(n) || n < 0) {
|
||||
return res.status(400).json({ error: `the cap for "${dimension}" must be a whole number of 0 or more` })
|
||||
}
|
||||
caps[dimension] = n
|
||||
}
|
||||
|
||||
const row = await settingsDb.put(actionId, { enabled: req.body.enabled, caps }, req.user.id)
|
||||
await activity.log({
|
||||
req,
|
||||
action: 'event.action.configured',
|
||||
detail: { actionId, enabled: Boolean(req.body.enabled), caps },
|
||||
})
|
||||
return res.json({
|
||||
action: {
|
||||
id: actionId,
|
||||
enabled: Boolean(row.enabled),
|
||||
configured: true,
|
||||
caps: row.caps,
|
||||
updatedAt: row.updated_at,
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
/** DELETE /api/v1/admin/events/:id — archive, never a hard delete */
|
||||
exports.archive = async (req, res) => {
|
||||
const id = asId(req.params.id)
|
||||
|
||||
Reference in New Issue
Block a user