Isolate internal bot-config route from the public listener (#33)
The GET /internal/bot-config route returns the DECRYPTED Discord bot token and was mounted on the same Express app / port 3000 that Pangolin proxies publicly. Its only guard was the BOT_INTERNAL_KEY shared secret, and .env.example shipped a placeholder default — so a forwarded path or a weak/unrotated key would expose the plaintext token to the internet. Move server<->bot internal traffic onto its own listener and fail fast on a weak key: - Add server/src/internalApp.js: a standalone Express app mounting requireInternalKey + /internal (and a no-secret /health), mirroring the bot's unpublished port-4100 pattern. - server.js starts a second listener on INTERNAL_PORT (default 3001), closed on graceful shutdown. - Remove the /internal mount from the public v1.router; the public app now 404s /api/v1/internal/bot-config even with a valid key. - Fail fast: new utils/botInternalKey.js rejects an empty, placeholder, or <16-char BOT_INTERNAL_KEY — fatal in production (exit 1), warning in dev. - docker-compose: bot SITE_INTERNAL_URL -> app:3001/internal/bot-config; document that INTERNAL_PORT stays unpublished. - .env.example (root/server/bot): document INTERNAL_PORT, the fail-fast behavior, and a defense-in-depth Pangolin deny rule for /api/v1/internal. Tests: add requireInternalKey.test.js and botInternalKey.test.js (node --test: 93 pass). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rao86n5cXpwAyjdBFEshV
This commit is contained in:
@@ -6,7 +6,8 @@ const ctrl = require('./internal.controller')
|
||||
const router = express.Router()
|
||||
|
||||
// Shared-secret gated, not session-gated — the caller is the bot process, not
|
||||
// a logged-in browser. Mounted before any auth/session middleware in v1.router.
|
||||
// a logged-in browser. This router is mounted on the standalone internalApp
|
||||
// (its own unpublished port), never on the public /api app. See internalApp.js.
|
||||
router.use(requireInternalKey)
|
||||
|
||||
router.get(
|
||||
|
||||
@@ -5,13 +5,13 @@ const v1Router = express.Router()
|
||||
const authRouter = require('./auth/auth.routes')
|
||||
const publicRouter = require('./public/public.routes')
|
||||
const adminRouter = require('./admin/admin.routes')
|
||||
const internalRouter = require('./internal/internal.routes')
|
||||
|
||||
v1Router.use('/auth', authRouter)
|
||||
v1Router.use('/public', publicRouter)
|
||||
v1Router.use('/admin', adminRouter)
|
||||
// Shared-secret gated (not session-gated) — server<->bot only, never exposed
|
||||
// through the public reverse proxy. See server/src/middleware/requireInternalKey.js.
|
||||
v1Router.use('/internal', internalRouter)
|
||||
// NOTE: /internal is intentionally NOT mounted here. Those routes return the
|
||||
// decrypted Discord bot token and must never share the public listener that
|
||||
// Pangolin proxies. They live on a separate, unpublished port via
|
||||
// server/src/internalApp.js (started in server.js). See issue #33.
|
||||
|
||||
module.exports = v1Router
|
||||
|
||||
Reference in New Issue
Block a user