feat(events): the integrations — lifecycle triggers, participants, results (Phase 10)
`EVENTS_PLAN.md` Phase 10. Core registers its own `event.` triggers, records who took part, publishes a results table, and announces a post through the legs the news pipeline already uses. Events owns none of the delivery: a run says what happened and an operator's rule decides who is told, so email, the in-app inbox, push tickles, Discord and the town crier all arrive without anything in `events/` growing a second delivery path. **No route was added and nothing moved.** The whole surface is two more derived fields on a run — `participants` and `resultsPublishedAt` — and a zero-line `routes.manifest.json` diff proves it. Seven triggers: six at ceiling `authenticated` / audience `subscribers`, exactly where `news.post` sits, and `run.failed` at `admin` on both halves. Every one keys its cooldown on the RUN. Two rules seeded, both off, under a third one-shot key so a deployment that has already stamped the Team and news keys still gets them. **The phase's own defect was a promise nothing kept.** `EVENTS.md` §I says a rehearsal runs for real "with announcements ceilinged to `staff`" — but a ceiling is declared on the TRIGGER, and a rehearsal fires the same trigger as the real thing, so the moment this phase gave a run something to announce, rehearsing a published event would have mailed every subscriber. The emit envelope now takes an optional `ceiling` and the send-time G24 gate applies `meet(declared, emitted)`. It only narrows; two incomparable ceilings refuse every rule rather than resolving to either. `MODULE_API_VERSION` stays 1.10.0, amended in place — `main` declares 1.9.0, so 1.10.0 has not shipped and the org lead's 2026-09-03 rule applies for the third time. Three defects the live walk found, none visible to a unit test: 1. **A channel that reported success while reaching nobody.** The seeded `run.started` rule named `push`, because §8.5 and the plan both do. Push delivery joins `notification_subscriptions`, only ever written for an id the preferences screen offered push for — and it offers push only for a registered STREAM. So the tickle went nowhere every time while `pushChannel.deliver` answered "tickle published". `event.run.started` is now a stream as well as a trigger; the other six are not. 2. **A trigger's `description` reaches a recipient.** It is the structural projection's `intro` fallback, so `run.failed`'s line ending "Staff-facing." put those words in an administrator's own inbox item. 3. **`affectedRows` cannot tell an insert from an unchanged upsert.** The connector sends `CLIENT_FOUND_ROWS`, so a "was this new" flag would have counted every idempotent retried collect as a fresh participant. And one caught before it shipped: ranking with a session variable is wrong here, because `query()` takes a pool connection per call — the variable would be set on one connection and read on another. A window function needs no session state. ## Verification - `npm test --prefix server` — **1981 pass, 1 fail**, and that one (`botScore.test.js`) passes standalone at 18/18: a file-level flake under parallel load. Run with an empty `MODULES_DIR`, as CI does. - `npm test --prefix client` — 362 pass, 0 fail. `npm run build` green. - Zero-line `routes.manifest.json` / `routes.guards.json` diff. - A live walk on a real rig: MariaDB, the site with no module, mailpit. The mail arrived, headed with the event's title and its start time in the shard's own zone; the rehearsal fired the same trigger and produced zero outbox rows where the real run produced three; `run.failed` reached the administrator's inbox and no player's; `core.announce.post` queued a second job without touching the news pipeline's back-pointer or `announced_at`; and `rankRun` and the upsert were run against real MariaDB 11. ## One thing for a reviewer, out of scope and not fixed **Every `#swagger.description` in this repo is truncated in the generated spec.** swagger-autogen does not honour a backslash-escaped apostrophe, so a description is cut at the first `\'` — 175 of the 177 in `server/src/router/**`. It is pre-existing and repo-wide. Only the one annotation this phase edits is fixed here (a typographic apostrophe), because otherwise this phase's own addition to it would be dead text. The rest wants its own change. - [x] AI-assisted: Claude Code (Opus 5). Docs: RunicGateway/docs#TBD. Co-Authored-By: Claude <noreply@anthropic.com> 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This commit is contained in:
@@ -701,6 +701,48 @@ test('the ceiling is re-checked at SEND time, so a module narrowing its declarat
|
||||
assert.equal(after2.enqueued, 0)
|
||||
})
|
||||
|
||||
test('a FIRING may narrow the ceiling, and every rule wider than that is refused', async () => {
|
||||
// EVENTS.md §I, and the case that forced it: a rehearsal fires exactly the
|
||||
// same trigger as the real thing, so without a per-firing bound, rehearsing a
|
||||
// published event mails every subscriber it. The declaration is a property of
|
||||
// the KIND of event; this is a property of the occasion.
|
||||
registries._reset()
|
||||
registerUoTrigger({ ceiling: 'authenticated', audience: 'authenticated' })
|
||||
addUser(11)
|
||||
optIn(10, 'uo.house.idoc_warning', 'email')
|
||||
optIn(11, 'uo.house.idoc_warning', 'email')
|
||||
addRule({ audience: 'authenticated' })
|
||||
|
||||
const wide = await engine.dispatch(event(), T0)
|
||||
assert.equal(wide.enqueued, 2)
|
||||
|
||||
const narrowed = await engine.dispatch(event({ subject: 'house-9', ceiling: 'staff' }), later(1000))
|
||||
assert.equal(narrowed.enqueued, 0)
|
||||
})
|
||||
|
||||
test('a firing may only ever NARROW — a wider ceiling than the declaration changes nothing', async () => {
|
||||
registries._reset()
|
||||
registerUoTrigger({ ceiling: 'owner', audience: 'owner' })
|
||||
addRule({ audience: 'owner' })
|
||||
|
||||
// `everyone` is the widest value the lattice has. `meet(owner, everyone)` is
|
||||
// `owner`, so the declaration still governs and the rule still fires.
|
||||
const out = await engine.dispatch(event({ ceiling: 'everyone' }), T0)
|
||||
assert.equal(out.enqueued, 1)
|
||||
})
|
||||
|
||||
test('two INCOMPARABLE ceilings meet to nothing and the gate refuses rather than guessing', async () => {
|
||||
// `owner` and `staff` have no common descendant — "fewer people" is not "less
|
||||
// exposure", which is the whole argument `modules/ceilings.js` is built on.
|
||||
// Picking one would be the guess §5.1a rule 3 exists to refuse.
|
||||
registries._reset()
|
||||
registerUoTrigger({ ceiling: 'owner', audience: 'owner' })
|
||||
addRule({ audience: 'owner' })
|
||||
|
||||
const out = await engine.dispatch(event({ ceiling: 'staff' }), T0)
|
||||
assert.equal(out.enqueued, 0)
|
||||
})
|
||||
|
||||
test('a rule for an unregistered trigger is dormant, not deleted and not an error', async () => {
|
||||
const rule = addRule({ trigger_id: 'uo.gone.away' })
|
||||
const listed = await rules.listAnnotated()
|
||||
|
||||
Reference in New Issue
Block a user