wtclaude
565a7d2c20
The last split PR of docs/website/API_V2_PLAN.md § Phase 2. public.routes.js,
player.routes.js and auth.routes.js are deleted; each group is now a directory
whose index.js owns the group gate and the mount table and declares no routes.
Every one of the 200 manifest routes is now in a capability router.
public/ posts (2) wiki (4) pages (2) shard (12) site (4, group root)
player/ account (8) shard (8) appeals (4), behind noindex + requireAuth
auth/ login (2) register (1) invite (2) password (3) session (2, root)
No URL moves. All four gates zero-diff: routes.manifest.json (200 public + 2
internal), routes.guards.json, swagger-output.json (198 operations), and
docs/website/api-route-inventory.json was already in sync. 434 tests green.
Notes on the non-mechanical parts:
- public/index.js and auth/index.js carry no group gate, deliberately, and say
so. The public surface is anonymous by contract (logged-out SPA, Discord bot,
Android ShardStreamClient on /public/shard/stream); /auth is where a caller
becomes authenticated. player/index.js gates on requireAuth only, never
requireRole('player') — staff are a superset of players.
- GET /auth/me has a mount-order dependency: use('/me', meRouter) matches the
bare /me, so the request runs meRouter's noindex + requireAuth and falls
through. session.router.js must stay mounted last. Verified by the
counterfactual — mounting it first still 401s but drops X-Robots-Tag, which
no manifest or guards file can see.
- loginGuards moved to auth/loginGuards.js (frozen) rather than being copied
into the three routers that spread it; sso.routes.js drops its duplicate.
- The :param shadowing check was re-run in dispatch order against the built
stack: 86 routes, 64 literal, none shadowed. /public/wiki/{categories,tags}
ahead of /:slug is the only ordering-sensitive pair.
Co-Authored-By: Claude <noreply@anthropic.com>
37 lines
1.4 KiB
JavaScript
37 lines
1.4 KiB
JavaScript
// Point the DB at a closed port BEFORE requiring the router (some public handlers
|
|
// build the pool). The /version endpoint itself is DB-free, so it answers without
|
|
// a connection; this just guarantees no stray query holds the process open.
|
|
process.env.DB_HOST = '127.0.0.1'
|
|
process.env.DB_PORT = '59999'
|
|
|
|
const { test, after } = require('node:test')
|
|
const assert = require('node:assert/strict')
|
|
|
|
const { startApp } = require('./_helper')
|
|
const version = require('../src/config/version')
|
|
const publicRouter = require('../src/router/v1/public')
|
|
const db = require('../src/utils/db')
|
|
|
|
after(() => db.close())
|
|
|
|
test('version config carries the service id + api/server versions', () => {
|
|
assert.equal(version.service, 'runic-gateway') // stable first-run identifier
|
|
assert.equal(version.api, 'v1') // API contract version (matches /api/v1)
|
|
assert.equal(typeof version.server, 'string')
|
|
assert.ok(version.server.length > 0)
|
|
})
|
|
|
|
test('GET /public/version returns the identity block (DB-free, 200)', async () => {
|
|
const app = await startApp((a) => a.use('/api/v1/public', publicRouter))
|
|
try {
|
|
const res = await fetch(app.url + '/api/v1/public/version')
|
|
assert.equal(res.status, 200)
|
|
const body = await res.json()
|
|
assert.equal(body.service, 'runic-gateway')
|
|
assert.equal(body.api, 'v1')
|
|
assert.equal(body.server, version.server)
|
|
} finally {
|
|
await app.close()
|
|
}
|
|
})
|