wtclaude
6195c76d61
Phase 2 PR 4 of docs/website/MODULE_SYSTEM.md §2.7. Adds server/src/modules/registries.js and moves core's own notification streams, announce leg and users-detail routes behind it, so the three seams §1.8 and §1.9 named are exercised on every boot before any module depends on them. Registering is validate-then-commit per registrant: the loader stages what a module claims and the second pass commits it, so a module that throws halfway through register() — or fails checkDeclared after it — leaves nothing behind. That is the registry-side twin of PR 2's second-pass mount rule. Four decisions, all the recommended option: - announce legs became a child table. `announce_job_legs` replaces the towncrier_*/discord_* column groups, so the leg set is data: core registers `discord`, module-uo will register `towncrier`, and a module cannot ALTER a core table to add its own. Backfill is guarded on information_schema (a SELECT of a dropped column is a parse error, not a runtime one) and the columns go with DROP COLUMN IF EXISTS. Verified against the live dev DB: three legacy jobs migrated faithfully, three replays, no duplicates. - `mapEvent` dropped from registerNotificationStreams. §1.8 already inverts the push path so a module owns fromShardEvent and calls core's publish() with a stream id it resolved; a second mapping mechanism was a leftover. The public safety filter, the kinds it reads and the streams it protects now live in one file and move together. - core registers through the same staging area a module uses, via an explicit registries.registerCore() in app.js before modules.load(). - core's six /admin/users/:id/shard/* paths now go through the `admin.users.detail` slot, and getUser moved back to admin.controller.js. Found on the way, and the reason two build tools changed: - scripts/routeManifest.js could not decode a parameterised mount. Its unwinder expected `(?:([^\/]+?))`; express 4.22 emits `(?:\/([^/]+?))` with the separator inside the group. The branch had never run. It threw rather than guessing, which is what it is for. - swagger-autogen cannot follow a route into an extension slot — the slot's router is created by declareSlot() and filled later, so there is no literal mount for a static parse. Regenerating deleted 407 lines and printed `Swagger-autogen: Success`, the spike's exact failure (MODULE_API.md §7.4). swagger/slotSpecs.js generates a fragment per filled slot and re-roots it at the prefix the router actually hangs at in the live app — read from the express stack via routeManifest's own mountPath, so the manifest and the spec cannot disagree. swagger/mergeSpec.js is the merge helper core owes for module fragments anyway (§6.1a), proved here against core's own slot first. 884 tests pass (856 before). routes.manifest.json is unchanged at 229 routes. The OpenAPI spec diff is two lines of intent: the retry endpoint's summary, and its `leg` no longer being a fixed enum. Co-Authored-By: Claude <noreply@anthropic.com>
46 lines
1.9 KiB
JavaScript
46 lines
1.9 KiB
JavaScript
// ── The Discord announce leg ───────────────────────────────────────────────
|
|
//
|
|
// CORE content — the Discord bot has no game logic (MODULE_SYSTEM.md §1.10), so
|
|
// this leg stays in core when module-uo leaves with the town crier. It is written
|
|
// in the same shape as a module's leg and registered through the same function
|
|
// (modules/registries.js registerAnnounceLeg), because a registry only core's
|
|
// hardcoded base bypasses is not exercised until a module arrives.
|
|
|
|
const botInternalClient = require('./botInternalClient')
|
|
const { articleUrl, baseUrl, legError } = require('../model/announceJobs/announceJobs.logic')
|
|
|
|
// Deliver. Returns the raw client result ({ ok, status, data, error }) — the
|
|
// client never throws, and classification is `classify`'s job.
|
|
async function dispatch(post) {
|
|
const base = baseUrl()
|
|
// Stored image paths are relative ("/uploads/x.png"); Discord embeds need an
|
|
// absolute URL.
|
|
const imageUrl = post.image_url ? new URL(post.image_url, base).toString() : null
|
|
return botInternalClient.announce({
|
|
title: post.title,
|
|
excerpt: post.excerpt,
|
|
url: articleUrl(base),
|
|
imageUrl,
|
|
})
|
|
}
|
|
|
|
// The bot's /internal/announce collapses failures (503 = not connected,
|
|
// 400 = no news channel configured) without surfacing Discord's own retry_after,
|
|
// so there is no reliable terminal signal to key on here. Retry every failure on
|
|
// the shared backoff; a genuine config problem simply exhausts its attempts and
|
|
// lands as `failed` in the admin panel, where the per-leg retry button re-runs it
|
|
// after the channel is set.
|
|
function classify(result) {
|
|
if (result && result.ok) return { outcome: 'done' }
|
|
return { outcome: 'retry', error: legError(result) }
|
|
}
|
|
|
|
const leg = {
|
|
leg: 'discord',
|
|
label: 'Discord #news',
|
|
dispatch,
|
|
classify,
|
|
}
|
|
|
|
module.exports = { leg, dispatch, classify }
|