fix(ci): restore the missing comma in core-ref.json #16

wtclaude · 2026-10-23T02:10:02-05:00

wtclaude commented

2026-10-23 02:10:02 -05:00

What & why

The template job failed on #15 (run 16) with:

SyntaxError: /workspace/RunicGateway/Integration-kit/ci/core-ref.json: Expected ',' or ']' after array element in JSON at position 2169

The "Clone core at the pinned ref" step reads the pin with require('./ci/core-ref.json'), and the file has not parsed since 0678047 (#14, 2026-10-06). My edit there left out the comma after "Before that move:" in the why array. So template has failed before reaching any check on every PR since: run 15 (#14) and run 16 (#15) both. #15 did not cause the failure; it inherited it.

This PR adds the one comma back. ref stays 6890a74, as #15 set it.

Why local runs missed it: checkCoreApi.js --core .core takes the core as a path and never reads core-ref.json. Only CI's clone step does, and I cloned by hand.

How it was tested

node -e "JSON.parse(...)" and node -p "require('./ci/core-ref.json').ref", the clone step's own read, both parse and give 6890a74c….
Every other check in template was run locally at 6890a74 for #15: checkCoreApi, imports, build, externals, swagger, and tests (server 82, client 20). This PR's CI run is the first one that can reach them in CI.

Checklist

I have read CONTRIBUTING.md.
The change builds and existing tests/checks pass locally.
I have added or updated tests/docs where it makes sense.
My commits are reasonably scoped with clear messages.

AI-assisted contributions (required)

AI tools were used. Tool(s): Claude Code (Claude Opus 5.5). I have reviewed and understand every change, and take responsibility for it. AI-authored commits are marked with a Co-Authored-By trailer.

License

I agree that my contribution is licensed under this project's license (GNU GPL v3.0 or later), and I have the right to contribute it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY

## What & why The `template` job failed on #15 (run 16) with: ``` SyntaxError: /workspace/RunicGateway/Integration-kit/ci/core-ref.json: Expected ',' or ']' after array element in JSON at position 2169 ``` The **"Clone core at the pinned ref"** step reads the pin with `require('./ci/core-ref.json')`, and the file has not parsed since **0678047** (#14, 2026-10-06). My edit there left out the comma after `"Before that move:"` in the `why` array. So `template` has failed before reaching any check on every PR since: run 15 (#14) and run 16 (#15) both. #15 did not cause the failure; it inherited it. This PR adds the one comma back. `ref` stays `6890a74`, as #15 set it. **Why local runs missed it:** `checkCoreApi.js --core .core` takes the core as a path and never reads `core-ref.json`. Only CI's clone step does, and I cloned by hand. ## How it was tested - `node -e "JSON.parse(...)"` and `node -p "require('./ci/core-ref.json').ref"`, the clone step's own read, both parse and give `6890a74c…`. - Every other check in `template` was run locally at `6890a74` for #15: checkCoreApi, imports, build, externals, swagger, and tests (server 82, client 20). This PR's CI run is the first one that can reach them in CI. ## Checklist - [x] I have read [CONTRIBUTING.md](CONTRIBUTING.md). - [x] The change builds and existing tests/checks pass locally. - [x] I have added or updated tests/docs where it makes sense. - [x] My commits are reasonably scoped with clear messages. ## AI-assisted contributions (required) - [x] AI tools were used. Tool(s): `Claude Code (Claude Opus 5.5)`. I have reviewed and understand every change, and take responsibility for it. AI-authored commits are marked with a `Co-Authored-By` trailer. ## License - [x] I agree that my contribution is licensed under this project's license (**GNU GPL v3.0 or later**), and I have the right to contribute it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY

wtclaude added 1 commit 2026-10-23 02:10:03 -05:00

fix(ci): restore the missing comma in core-ref.json

PR Checks / prose (pull_request) Successful in 10s

Details

PR Checks / template (pull_request) Successful in 48s

Details

2f018999c3

The template job's "Clone core at the pinned ref" step reads the pin with
require('./ci/core-ref.json'), and the file has not parsed since
0678047 (2026-10-06): the "why" array lost the comma after "Before that
move:". So the job has failed on every PR since, run 15 and run 16 (#15)
included, before it reached a single check.

The local runs missed it because checkCoreApi takes the core as
`--core .core` and never reads this file. Only the CI clone step reads
it. The file now parses, and `ref` is 6890a74 as #15 set it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E14m6SuuY6i1vASFeGDBeY

whitlocktech merged commit 0297f81ae2 into main

2026-10-23 02:14:58 -05:00

whitlocktech deleted branch fix/core-ref-json

2026-10-23 02:14:59 -05:00

whitlocktech referenced this issue from a commit

2026-10-23 02:15:01 -05:00

Merge pull request 'fix(ci): restore the missing comma in core-ref.json' (#16) from fix/core-ref-json into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RunicGateway/Integration-kit#16