The kit's `template/`: a complete, minimal Runic Gateway module a reader copies,
renames, and runs before reading a chapter. Slice 0 landed the workflow that runs
it; this is the tree that workflow was written against, so the `template` job
arms itself with no edit to the guard.
Installed into a real core it adds one public page at `/examplegame/status`, a nav
row pointing at it, one API route described in an OpenAPI fragment core merges,
one table created by an idempotent schema fragment and dropped by a purge file,
and both lifecycle hooks. That is deliberately less than a real module does; what
it is complete about is the shape — every seam used once, with the reasoning next
to it.
Four decisions, settled with the org lead:
1. **Public tier only, plus the lifecycle hooks.** §2.11.1 d1's "one public route",
plus enough to show the whole vertical seam once. Admin and player tiers become
worked examples quoted from module-uo in chapter 2 rather than two thirds of a
tree the reader deletes on day one.
2. **The release workflow ships as a file, in BOTH flavours** — `.gitea/` and
`.github/`. Neither runs where it sits (a workflow is only read from a
repository root) and each arms itself when the reader's copy is its own repo.
Packaging is the part of a module that cannot be guessed at, and the kit's
audience is outside this org, so assuming Gitea would have been assuming our
own deployment. Core installs from a URL and does not care where the release
lives — only that the host is on the operator's `MODULE_SOURCE_HOSTS`.
3. **A rename checklist that CI verifies**, not a rename script. `template/README.md`
carries the table; `scripts/checkRenameSites.js` holds it against the tree in
both directions — an unlisted file that still carries the placeholder fails, and
so does a listed file that no longer does. The second half is the one usually
left out and the more valuable: a row that has stopped matching reads as
instructions to edit something that is not there. Same rule core's identifier
check follows about its own exemptions. It has its own ten-test suite, run by
CI as `node --test`, because a check that has never been shown to fail is a
check nobody knows the state of.
4. **A neutral invented game.** One deviation from the literal answer, forced by
decision 3: the id is `examplegame`, not `example`. The checklist check is a
text search, and `example` occurs in ordinary English ("for example") all over
prose that is not a rename site — a placeholder that cannot occur by accident is
what makes the check answerable instead of a source of false alarms someone
learns to ignore.
**The pin moves to the 1.4.0 bump** (website `edge` 1b692bf), which is what
`template/module.json` declares as `coreApi`. Slice 0 pinned its parent, before
1.4.0 existed, so `checkCoreApi.js` arms for the first time here — it asserts
EQUALITY, and its failing on the next contract bump is the system working.
Also in CI: the client tests now run AFTER the build (two of them read the built
chunk and skip without one — run first, the job reports green while asking nothing
about the artifact that ships), and `check:swagger` verifies the committed
fragment is current.
## The finding: an UPDATE that changes nothing does not touch ON UPDATE CURRENT_TIMESTAMP
Every suite passed, both guards passed, the chunk built, the module loaded into a
real core and the page rendered correctly. Two hours later the same page said the
world was offline, and it was wrong.
`updated_at` was declared `ON UPDATE CURRENT_TIMESTAMP`, and MariaDB fires that
only when an UPDATE actually CHANGES a value. The boot refresh writes the same
numbers every thirty seconds — which is exactly what a quiet game looks like — so
the timestamp froze at the first write, the row crossed the freshness window, and
the model correctly reported a stale row as offline. Verified against the live
database: two hours of refreshes, `updated_at` still the boot timestamp.
No test in this repo could see it. The model takes its clock as an argument, and
nothing in a suite runs the same UPDATE twice against a real database. It is only
visible as a page that was right when you looked at it and wrong an hour later.
The writer now sets `updated_at = CURRENT_TIMESTAMP` explicitly and the column
drops the clause that was not doing what it looked like it was doing; both carry
the reasoning. Re-verified end to end: the timestamp advances every interval and
the API reports fresh.
Falling out of the fix, the schema fragment gained the rule the reader hits next:
**changing a table is an ALTER, never an edit to its CREATE** — `CREATE TABLE IF
NOT EXISTS` does nothing when the table exists, so an edited column definition
takes effect on a fresh install and on no existing one, which is the worst
possible split because your development database is usually the fresh one.
## Verified
- 29 server tests, 18 client tests, 10 kit-script tests; `check:imports`,
`check:externals`, `check:swagger` and `checkCoreApi` all green, run in CI's own
order from a clean `npm ci`.
- Browser smoke (MODULE_API.md §7.7) against a real core built from the pinned
ref: module `started`, published on `/api/v1/public/modules`, chunk served
`no-cache` with the right MIME from the entry's directory while `module.json`
and the server source 404, script tag injected after core's bundle, the page
rendering inside core's own chrome, the nav row interleaved into the public
header between Wiki and About, SPA navigation into it from another page, the
module's path and schema and tag merged into `/api/docs.json`, and
`[examplegame] registered against core API 1.4.0` in the console with no CSP
report and no React error.
Refs: MODULE_SYSTEM.md §2.11.1 (slice 1), MODULE_API.md §2.x, §3.x, §5.1, §7.7.
Co-Authored-By: Claude <noreply@anthropic.com>
172 lines
7.6 KiB
YAML
172 lines
7.6 KiB
YAML
# Gate every pull request into `main`. This repo is documentation plus a template
|
|
# module, so the checks are about whether the documentation is still TRUE rather
|
|
# than whether software works.
|
|
#
|
|
# ── What each job is really asking ───────────────────────────────────────────
|
|
#
|
|
# • `prose` — the documentation, checked as far as documentation can be. Every
|
|
# relative link resolves, and no link pins a reader to a commit snapshot of a
|
|
# document that moves. Nothing is fetched: this project's Gitea is self-hosted,
|
|
# so an HTTP check would fail on a runner without credentials and teach
|
|
# everyone to ignore red. What breaks in practice is a relative path after a
|
|
# file moves, and that is answerable offline.
|
|
#
|
|
# It also holds `template/README.md`'s rename checklist against the template
|
|
# tree, in both directions — an unlisted file that still carries the
|
|
# placeholder, and a listed file that no longer does, are both failures. That
|
|
# checklist is the only instruction a reader has for the first thing they do
|
|
# with the template, and it is prose, so it rots the way prose does. The two
|
|
# checks in `scripts/` have their own unit tests, run in the same job.
|
|
#
|
|
# • `template` — the interesting one, and the anti-rot mechanism of the whole
|
|
# repo (MODULE_SYSTEM.md §2.11.1 d2). It clones CORE at the ref pinned in
|
|
# `ci/core-ref.json` and asks three things:
|
|
#
|
|
# 1. does `template/module.json`'s `coreApi` still EQUAL that core's
|
|
# `MODULE_API_VERSION`? Equality, not "satisfies" — a range check would
|
|
# stay green across a contract bump, and green would then mean "the
|
|
# template still loads" when we need it to mean "someone has re-read the
|
|
# book since the contract changed". This failing is the system working.
|
|
# 2. does the template still build? A kit whose examples do not compile is
|
|
# worse than no kit, because the reader trusts it first.
|
|
# 3. do the template's own boundary guards still pass? They are the same
|
|
# checks a real module ships (MODULE_API.md §5.1, §3.6), and the template
|
|
# is what teaches a newcomer that they exist.
|
|
#
|
|
# ── The guard, and why the template job can report green with no template ────
|
|
#
|
|
# Slice 0 is this scaffold; the template lands in slice 1. Rather than leave the
|
|
# repo ungated in between, or land a workflow that red-Xes every docs PR until
|
|
# there is something to build, the template steps are conditional on
|
|
# `template/module.json` existing. Before it lands the job prints why it did
|
|
# nothing; the moment the file appears the job arms itself with no edit here.
|
|
# Same guard Module-uo#1 used through its own planning phase.
|
|
#
|
|
# Enforcement (one-time, in the Gitea UI):
|
|
# Repository Settings → Branches → Branch Protection (rule for `main`)
|
|
# • Enable Status Check
|
|
# • Status check patterns: PR Checks / *
|
|
# Gitea only lists a context in its dropdown after it has reported once, so let
|
|
# this run on one PR first. The glob keeps matching as jobs are added.
|
|
#
|
|
# Runner: the shared self-hosted `ubuntu-latest` runner. Node only — no database,
|
|
# no Docker socket.
|
|
|
|
name: PR Checks
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [main]
|
|
|
|
concurrency:
|
|
group: pr-checks-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
env:
|
|
NPM_CONFIG_FETCH_RETRIES: 5
|
|
NPM_CONFIG_FETCH_RETRY_MINTIMEOUT: 20000
|
|
NPM_CONFIG_FETCH_RETRY_MAXTIMEOUT: 120000
|
|
|
|
jobs:
|
|
prose:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 10
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 20
|
|
|
|
# No dependencies on purpose — every step in this job has to run on a clone
|
|
# with nothing installed, which is also how a reader will run them.
|
|
- name: Check every link in the book
|
|
run: node scripts/checkLinks.js
|
|
|
|
- name: Check the rename checklist against the template
|
|
run: node scripts/checkRenameSites.js
|
|
|
|
# The checks, checked. A check that has never been shown to fail is a check
|
|
# nobody knows the state of — and this one gates the instructions for the
|
|
# first thing a reader does.
|
|
- name: Test the checks themselves
|
|
run: node --test scripts/checkRenameSites.test.js
|
|
|
|
template:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 20
|
|
|
|
- name: Is there a template yet?
|
|
id: guard
|
|
run: |
|
|
if [ -f template/module.json ]; then
|
|
echo "present=true" >> "$GITHUB_OUTPUT"
|
|
else
|
|
echo "present=false" >> "$GITHUB_OUTPUT"
|
|
echo "No template/module.json — the template lands in Phase 5 slice 1."
|
|
echo "The steps below are skipped until it does; see this file's header."
|
|
fi
|
|
|
|
# Anonymous HTTPS, and a full clone rather than a shallow one: the pin is a
|
|
# commit sha, and `--depth 1` can only fetch a branch tip.
|
|
- name: Clone core at the pinned ref
|
|
if: steps.guard.outputs.present == 'true'
|
|
run: |
|
|
REPO=$(node -p "require('./ci/core-ref.json').repo")
|
|
REF=$(node -p "require('./ci/core-ref.json').ref")
|
|
echo "core: $REPO @ $REF"
|
|
git clone --quiet "$REPO" .core
|
|
git -C .core checkout --quiet "$REF"
|
|
|
|
- name: Is the kit still written against this core? (MODULE_SYSTEM.md §2.11.1 d2)
|
|
if: steps.guard.outputs.present == 'true'
|
|
run: node scripts/checkCoreApi.js --core .core
|
|
|
|
- name: Install the template's deps
|
|
if: steps.guard.outputs.present == 'true'
|
|
run: |
|
|
npm ci --prefix template/server
|
|
npm ci --prefix template/client
|
|
|
|
- name: Check the template's module boundary (MODULE_API.md §5.1)
|
|
if: steps.guard.outputs.present == 'true'
|
|
run: npm run check:imports --prefix template/server
|
|
|
|
# The build comes before the externals check because that check reads the
|
|
# BUILT chunk: whether `import { useState } from 'react'` became core's React
|
|
# or a bare specifier no browser can resolve is decided by vite.config.js, and
|
|
# is invisible in source.
|
|
- name: Build the template's client chunk
|
|
if: steps.guard.outputs.present == 'true'
|
|
run: npm run build --prefix template/client
|
|
|
|
- name: Check the built chunk's externals (MODULE_API.md §3.6)
|
|
if: steps.guard.outputs.present == 'true'
|
|
run: npm run check:externals --prefix template/client
|
|
|
|
- name: Run the template's tests
|
|
if: steps.guard.outputs.present == 'true'
|
|
run: npm test --prefix template/server
|
|
|
|
# After the build, and that ordering is the point: two of the client tests
|
|
# read the BUILT chunk and SKIP when there is none. Run before the build,
|
|
# this job would report green while asking nothing about the artifact that
|
|
# ships — which is exactly how the first real module's two artifact tests sat
|
|
# green and inert.
|
|
- name: Run the template's client tests
|
|
if: steps.guard.outputs.present == 'true'
|
|
run: npm test --prefix template/client
|
|
|
|
# The committed OpenAPI fragment, regenerated and compared. Core merges that
|
|
# file verbatim into its own spec, so a stale one documents a URL surface the
|
|
# module does not serve — and nothing at runtime will ever say so.
|
|
- name: Check the template's OpenAPI fragment is current (MODULE_API.md §2.8)
|
|
if: steps.guard.outputs.present == 'true'
|
|
run: npm run check:swagger --prefix template/server
|