feat(events): the UO half of the Event System, and the core pin comes home (Phase 16b cutover, 3 of 6) #34

Merged

whitlocktech merged 14 commits from chore/events-cutover-repin into main 2026-09-10 01:23:39 +00:00

Conversation 1 Commits 14 Files Changed 28 +5260 -50

wtclaude commented 2026-09-10 00:49:04 +00:00

Member

Copy Link

The Event System cutover, step 3 of 6 (EVENTS_PLAN.md Phase 16b). This is edge's 13 commits plus the ci/core-ref.json re-pin riding on them, which is why it is a branch rather than edge → main directly: the pin has to name a website main sha carrying MODULE_API_VERSION 1.10.0, and that sha only came into existence when website#199 merged half an hour ago.

What lands

Phase
9	UO wave 1 — uo.broadcast, uo.towncrier.post, uo.news.post, the uo.broadcasts budget dimension and three atlas option sources.
11a / 11b	The idempotency key on every event-driven write (which is what made uo.broadcast retryable at all), the new champ.boss.killed kind, lease deadlines and the participation ledger.
12a	The five world verbs an author sees — uo.creature.spawn, uo.boss.spawn, uo.npc.place, uo.gate.open, uo.decor.place — over one command family on the wire.
12b	What an event borrows: object-property leases, the seasonal toggle, the item grant, the world save; values on a string lease and searchable option sources, which the 6,707-entry spawner dropdown forced.
16a	The two defects the acceptance walk found — the atlas import that could not run on a stock ServUO tree, and a teardown that was a no-op reporting success.

module.json declares version 0.6.0 and coreApi ^1.10.0. The protocol pin (DEFAULT_PROTOCOL) and both of its declarations in db/schema.sql are at 7, with the one-shot uo_link_protocol_7_migrated migration that carries an existing deployment's stored row from 5 to 7 — so an operator upgrading does not come up 409-ing against the protocol-7 sidecar, and one who has deliberately pinned an older sidecar stays pinned.

The re-pin, and why nothing else moved with it

ci/core-ref.json pointed at a website edge sha for the length of this window (org lead, 2026-09-04). That was not laziness: api.registerEventActions exists only from MODULE_API 1.10.0, so under the old main pin the frozen-manifest job's register() threw and this module did not load at all — the job would have been red by construction for eight phases while a real regression hid behind it. The cutover put 1.10.0 on main, so the pin comes home to 655fbf3f.

routes.manifest.json needed no regeneration. I ran the frozen-manifest job's own steps against that exact ref — core's manifest alone, this module installed into core/modules/uo, core's manifest again, then frozenManifest.js --check:

core alone           route manifest up to date (280 routes)
with this module     349 public + 4 internal
frozen check         routes.manifest.json is current — 73 routes, all documented

website's main and edge are the identical tree (930422ff), which is why a measurement taken on the branch holds for the merge.

This is also the move that turns Integration-kit green again: checkCoreApi asserts equality against whatever core its own pin names, and the kit's main has been red since #10 merged. Its re-pin is step 5.

Verification

622 server tests pass. Beyond that, every phase in here was walked on a real rig, and Phase 16a walked the whole of it — ServUO 57.4 (208k items, 42k mobiles) → a protocol-7 sidecar → core with this module installed from a release-shaped bundle. The atlas imports 309 decor types, 6,455 spawn points, 800 creatures, 558 landmarks, 387 regions; a four-phase run's teardown leaves the shard owning 0 of the 21 objects it spawned.

Merging this cuts the module release that 16b's re-verify needs. The shard half of that walk is already standing from real released artefacts: the released installer resolved bundle 2026.09.10 (protocol 7), verified both component checksums, did a first install into a stock 57.4 tree (add=30 change=1), the overlay compiled 0 Warning(s) 0 Error(s), and the shard came up [Bridge] enabled=True … events=True and dialed the sidecar, which logged server.hello for 208,568 items.

• AI-assisted: written with Claude Code (Claude Opus 5).

🤖 Generated with Claude Code

https://claude.ai/code/session_016wDDVXWMDz82WqE1i969r4

The Event System cutover, step 3 of 6 (`EVENTS_PLAN.md` Phase 16b). This is `edge`'s 13 commits **plus the `ci/core-ref.json` re-pin riding on them**, which is why it is a branch rather than `edge` → `main` directly: the pin has to name a website `main` sha carrying `MODULE_API_VERSION` 1.10.0, and that sha only came into existence when `website#199` merged half an hour ago. ## What lands | Phase | | |---|---| | **9** | UO wave 1 — `uo.broadcast`, `uo.towncrier.post`, `uo.news.post`, the `uo.broadcasts` budget dimension and three atlas option sources. | | **11a / 11b** | The idempotency key on every event-driven write (which is what made `uo.broadcast` retryable at all), the new `champ.boss.killed` kind, lease deadlines and the participation ledger. | | **12a** | The five world verbs an author sees — `uo.creature.spawn`, `uo.boss.spawn`, `uo.npc.place`, `uo.gate.open`, `uo.decor.place` — over one command family on the wire. | | **12b** | What an event borrows: object-property leases, the seasonal toggle, the item grant, the world save; `values` on a string lease and searchable option sources, which the 6,707-entry spawner dropdown forced. | | **16a** | The two defects the acceptance walk found — the atlas import that could not run on a stock ServUO tree, and a teardown that was a no-op reporting success. | `module.json` declares `version` 0.6.0 and `coreApi` `^1.10.0`. The protocol pin (`DEFAULT_PROTOCOL`) and both of its declarations in `db/schema.sql` are at **7**, with the one-shot `uo_link_protocol_7_migrated` migration that carries an existing deployment's stored row from 5 to 7 — so an operator upgrading does not come up 409-ing against the protocol-7 sidecar, and one who has deliberately pinned an older sidecar stays pinned. ## The re-pin, and why nothing else moved with it `ci/core-ref.json` pointed at a website **`edge`** sha for the length of this window (org lead, 2026-09-04). That was not laziness: `api.registerEventActions` exists only from MODULE_API 1.10.0, so under the old `main` pin the frozen-manifest job's `register()` threw and this module did not load at all — the job would have been red by construction for eight phases while a real regression hid behind it. The cutover put 1.10.0 on `main`, so the pin comes home to `655fbf3f`. **`routes.manifest.json` needed no regeneration.** I ran the frozen-manifest job's own steps against that exact ref — core's manifest alone, this module installed into `core/modules/uo`, core's manifest again, then `frozenManifest.js --check`: ``` core alone route manifest up to date (280 routes) with this module 349 public + 4 internal frozen check routes.manifest.json is current — 73 routes, all documented ``` website's `main` and `edge` are the **identical tree** (`930422ff`), which is why a measurement taken on the branch holds for the merge. This is also the move that turns `Integration-kit` green again: `checkCoreApi` asserts equality against whatever core its own pin names, and the kit's `main` has been red since `#10` merged. Its re-pin is step 5. ## Verification `622` server tests pass. Beyond that, every phase in here was walked on a real rig, and Phase 16a walked the whole of it — ServUO 57.4 (208k items, 42k mobiles) → a protocol-7 sidecar → core with this module installed from a release-shaped bundle. The atlas imports **309 decor types, 6,455 spawn points, 800 creatures, 558 landmarks, 387 regions**; a four-phase run's teardown leaves the shard owning **0** of the 21 objects it spawned. **Merging this cuts the module release that 16b's re-verify needs.** The shard half of that walk is already standing from real released artefacts: the released installer resolved bundle **2026.09.10 (protocol 7)**, verified both component checksums, did a first install into a stock 57.4 tree (`add=30 change=1`), the overlay compiled `0 Warning(s) 0 Error(s)`, and the shard came up `[Bridge] enabled=True … events=True` and dialed the sidecar, which logged `server.hello` for 208,568 items. - [x] AI-assisted: written with Claude Code (Claude Opus 5). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016wDDVXWMDz82WqE1i969r4

wtclaude added 14 commits 2026-09-10 00:49:06 +00:00

feat(events): UO wave 1 — the verbs that need no protocol change (Phase 9) ... 57419111e6

module-uo registers its first event actions: `uo.broadcast`,
`uo.towncrier.post` and `uo.news.post`, plus the `uo.broadcasts` budget
dimension and the three spawn-atlas option sources. The write plane they use
has existed since protocol 2.1; what is new is the declaration that lets the
event engine drive it unattended.

Three things the tree corrected about the plan:

- The plan's `on_failure: 'skip'` for `uo.broadcast` is already the default for
  `risk: 'notify'`, and `on_failure` is what happens AFTER the retries. The
  lever a module actually has is the failure envelope, so the action answers
  `retry: false` to everything — and every action declares `budgetMs: 15000`,
  because core's 10s default deadline fires before `uoLinkClient`'s 12s timeout
  and `classify()` answers `retry` for a timeout without asking the module.
  Without the budget the retry refusal is unreachable.
- `reconcile()` needs no protocol work. A shard restart wipes both the crier
  lines and an event's news article, so `perform()` stamps the shard `bootId`
  into the resource payload and `reconcile()` reports in force exactly the rows
  whose stamp still matches — correct for the module's own trigger and for
  core's boot sweep alike. `shardIngest` fires `ctx.events.reconcile()` on a
  changed `bootId`, after `recordStatus` so the comparison reads the new boot.
- Event articles post under `evt-<idempotencyKey>`, because `newsGump.js` uses
  the bare website post id and re-pushes that set on every reconnect.

`ci/core-ref.json` moves to a website `edge` sha for the length of this
workstream: `registerEventActions` exists only from MODULE_API 1.10.0, so under
the old `main` pin the module does not load at all. Verified locally — the
frozen-manifest rig passes against the new pin.

Co-Authored-By: Claude <noreply@anthropic.com>

fix(events): three defects the live rig found, two of them data loss ... 021f191f65

The whole-rig walk (ServUO + sidecar + website) against a real two-phase event.

- **A WS reconnect would have orphaned every live resource.** The backfill
  replays the last several `server.hello` frames in order — this rig saw three,
  each with a different `bootId` — so every replayed frame reads as a restart,
  and the intermediate ones compare a resource stamped with the CURRENT boot
  against a boot that ended hours ago. The row is then `orphaned`: a live crier
  line core will never take down again, lost to nothing worse than the website
  reconnecting. Gated on `!fromBackfill`, the rule the engagement fan-out and
  the SSE broadcast beside it already state. The website-was-down case is not
  missed — core asks every module at its own boot.
- **The shard explains its refusals and the run log dropped the explanation.**
  A 403 body reads `{"reason":"admin write plane disabled"}`; `legError` looks
  for `data.message`, finds nothing, and reports "sidecar responded 403". For a
  staff member clicking a button that is survivable. For an event that ran at
  four in the morning the run log is the only place anyone will learn why.
- **The "not retried" clause explained the wrong thing on a permanent status.**
  A 403 will not succeed on any attempt, so telling an operator it was not
  retried "because a repeat would announce twice" points them at a policy
  decision instead of at the switch they have to flip. The clause is now added
  only where a retry was genuinely given up, and 403/404 join the statuses the
  keyed verbs treat as terminal.

Co-Authored-By: Claude <noreply@anthropic.com>

Merge pull request 'feat(events): UO wave 1 — the verbs that need no protocol change (Phase 9)' (#28) from feature/events-phase-9 into edge ... cf60932c85

Reviewed-on: #28

feat(events): send the idempotency key, and declare champ.boss.killed (Phase 11a) ... dc13515927

The website's half of protocol 6.

Every event-driven write now carries the step's idempotency key, and `uo.broadcast`
stops being un-retryable. Phase 9 shipped it answering `retry: false` to everything
including a 503 from a shard that was merely restarting, with a comment naming the
line that would change when the wire could refuse a repeat. This is that line: it
defers to `sidecarFailure`, the same helper its two siblings already used, so the
hand-rolled variant that forced every outcome terminal is gone rather than re-tuned.

One verb was less idempotent than its own id made it look. Both keyed verbs post
under a run-scoped id and a repeat replaces — but `news.add` with `announce: true`
makes the criers proclaim the title on every post, so a retry replaced the article
silently and proclaimed it again. The key stops the second proclamation.

`champ.boss.killed` is mapped to the `champs` feature (rule 2 would otherwise fail
it closed to admin), with `damagers` a nested `staff` field rule: the kill is public
because a champion falling is what the board is for, the ranked roll of who was
strong enough to fell it is not. `uo.champ.boss_killed` is declared as a trigger —
which is what makes it usable as an event PHASE CONDITION, since a condition is
written over a trigger firing — and it carries `damagerCount`, never a damager name,
because a trigger variable reaches mail an operator may address to every subscriber.

Its seeded rule is its own group, `champ-boss-killed-v1`: `triggers-v1` is stamped
once under a settings guard, so appending a 27th entry would have reached fresh
installs and nothing else. It also ships email+inapp and NOT push, and the comment
says why — no trigger in this module is also a registered stream, so no engagement
rule here can push. That is pre-existing in twenty rules and flagged rather than
fixed; this one declines to be the twenty-first.

Co-Authored-By: Claude <noreply@anthropic.com>

Merge pull request 'feat(events): send the idempotency key, declare champ.boss.killed (Phase 11a)' (#29) from feature/protocol-v6-idempotency into edge ... bf9a702cfa

Reviewed-on: #29

feat(events): one lease and the participation verbs (Phase 11b) ... 88bfe9310e

The UO half of protocol 6 part b. No route added, no schema change, no
MODULE_API bump.

`uo.playercaps.skillcap` is the one lease, and the catalog is short because
ServUO made it short: of the 158 non-Bridge `Config.Get` call sites in
`Scripts/`, roughly eight are read live. This one is read inside
`CharacterCreation.cs`'s per-character path, so it is both live and observable --
which is what "proven" has to mean, since the failure an allowlist exists to
prevent is a key that applies cleanly and changes nothing.

Its `apply()` sends a DURATION rather than the deadline: an absolute time
computed here and honoured there is measured against two clocks, and a shard
running ten minutes fast would restore a ten-minute lease the instant it took it.
Its `restore()` turns `lease.drifted` into `{ drifted: true, current }` rather
than an error, because core records drift as a distinct successful outcome and an
error would put the row on the retry ladder. Its `inForce()` asks whether the
shard still HOLDS the lease, never whether the value still matches -- see the
core PR.

`uo.participation.open` / `.collect` count who took part and file them on the
success envelope. `open` is the one resource in this module that must NOT
reconcile by boot stamp: every other resource here lives in shard memory, so a
changed bootId IS the proof it is gone, while the participation ledger is written
into the world save precisely so it survives that restart. It asks instead.

Co-Authored-By: Claude <noreply@anthropic.com>

Merge pull request 'feat(events): one lease and the participation verbs (Phase 11b)' (#30) from feature/events-p11b-leases-participation into edge ... c11c130438

Reviewed-on: #30

feat(events): the five world verbs an author sees (Phase 12a) ... 89be9d6a4e

`uo.creature.spawn`, `uo.boss.spawn`, `uo.npc.place`, `uo.gate.open` and
`uo.decor.place`, over protocol 7's one command family. Five actions because
five is what an author has; one `perform`/`revert`/`reconcile` because on the
wire they are one thing.

Five new budget dimensions -- `uo.creatures`, `uo.bosses`, `uo.npcs`,
`uo.decor`, `uo.gate.minutes` -- all declared by THIS MODULE (org lead,
2026-09-07). Core meters whatever dimensions a module declares and holds no UO
knowledge, which is the whole of what MODULE_API means by game-agnostic. A gate
is priced in minutes rather than in gates: one standing all day and twelve
standing five minutes each are not the same imposition on a world.

`reconcile()` ASKS the shard, and is the one place in this file that must not
use `reconcileByBootId`. A crier line lives in shard memory, so a changed
`bootId` IS proof it is gone; a spawned creature is in the world SAVE and
survives the restart the stamp would report it lost by. Anything `world.owned`
does not list is gone -- safe only because the shard's registry and the objects
it describes are written by the same save.

Teardown reports `gone` as success and `refused` as failed. A creature a player
killed is the point of having spawned it, and a run that ended `incomplete`
because its event worked would be a report nobody could read. `refused` means
the shard denies this run ever owned the serial, so nothing will delete it
through this path and the row must land unresolved with a reason.

The atlas gains a decoration index, parsed from the shard's own
`Data/Decoration/**/*.cfg` -- 120 files, read RECURSIVELY because the real tree
nests two deep and a flat read would index a fraction of it while looking like
it worked. 313 distinct types. The decor verb resolves through it rather than
passing a type name through, which keeps the verb to this shard's own decoration
vocabulary AND fetches the item id: `Static` alone accounts for 5031 placements
under 1992 different graphics, so a bare type name places the wrong thing.
`PARSER_VERSION` -> 3, so an already-imported tree is re-read.

Two things the build found in code that had already shipped:

`uo.options.creatures` answered with the atlas SLUG -- unique, stable, and not
something the shard can build, because a creature is constructed from a ServUO
class name and `orc-brute` is not one. The atlas's `name` is the raw type token
from the spawn files, so the fix was to stop discarding the half that works.
Safe to change because Phase 12a is the source's first consumer; the file said
so when it shipped.

`uo.npc.place` could not be performed from its own required params. Both ends
refuse an oracle with neither a greeting nor a line, but both fields were
optional -- so a cross-field rule sat where no authoring form could render it.
The greeting is now `required`, which says the same thing in the contract
itself. Caught by the existing dry-run sweep, which is a better argument for
that test than anything written about it when it shipped.

605 tests pass. `swagger-fragment.json` is stale on `edge` already and this
phase adds no route, so it is left alone.

Refs: docs/link/v7.md, docs/website/EVENTS_PLAN.md Phase 12a

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016wDDVXWMDz82WqE1i969r4

Merge pull request 'feat(events): the five world verbs an author sees (Phase 12a)' (#31) from feature/events-p12a-world-verbs into edge ... 0b142adb81

Reviewed-on: #31

feat(events): what an author borrows, and two one-shots (Phase 12b) ... 10fde87724

Five targeted leases over two planes, the item grant, the world save, and the
atlas work the spawner dropdown needed.

FIVE LEASES, ONE FACTORY

`uo.spawner.maxcount`, `.mindelay`, `.maxdelay`, `.running` and
`uo.seasonal.status`. The four callables differ only in which key they name, so
they are built rather than repeated: five copies would be five chances for one of
them to forget the drift check, which is the one thing §F says a lease must not
be allowed to skip.

It is `MaxCount`, not the `Amount` EVENTS_PLAN.md named -- there is no such
property on ServUO 57.4. `MinDelay`/`MaxDelay` are TimeSpans, so the wire carries
SECONDS: the spawn files' own `DelayInSec` flag proves both units are in use on a
real tree, and a unit that cannot express five seconds cannot express this
shard's own data.

The seasonal lease is a THREE-value enum over EIGHT events. §G called
`GetEntry(type).Status` "a nine-value enum" and had it backwards: `EventStatus`
has three values and it is `EventType` that has nine entries. Eight rather than
nine because `TreasuresOfTokuno` is excluded -- `IsActive()` reads its own
`DropEra` rather than `Status`, so leasing it would apply cleanly, read back,
restore cleanly and do nothing at all.

Two behaviours worth the review. `inForce()` reads the frame's `holds` rather
than a row's `held` flag, because a catalog walk can enumerate the keys but never
the holds on a targeted one. And a target that VANISHED mid-run is a SUCCESSFUL
restore: there is nothing to give back, and reporting it failed would leave a
ledger row unresolved for ever over an object that is gone -- 12a's `gone` in the
lease plane's vocabulary.

THE GRANT NAMES A RUN, NEVER A RECIPIENT LIST

Core has the participants in `event_run_participants`, but a module cannot read
core's tables -- so the alternative was a new core surface handing them over. Not
needed: the shard has held the run's ledger since it opened, keyed by the same
serials core stores as `member_key`.

And the grant is RETRYABLE. §G called it un-retryable because a lost
acknowledgement and a grant that never applied were the same event, which is
exactly the argument that made `uo.broadcast` answer `retry: false` in Phase 9.
Protocol 6's idempotency key closes it. `uo.rewards` counts ITEMS rather than
grants: 500 gold to forty people and a candle to forty people are not the same
imposition.

THE ATLAS KEEPS UniqueId AGAIN, AND THE SPAWNER SOURCE SEARCHES

The parser has read `<UniqueId>` and thrown it away since the atlas shipped, on a
line citing a committed artifact -- there is no committed artifact, as
`spawnAtlasSource.js` says in its own header. It is the ONLY name for one
particular spawner that exists off the shard, so a property lease could not have
had a dropdown without it. `PARSER_VERSION` -> 4 so an unchanged tree is re-read.

`uo.options.spawners` is the first searchable source and the first that had to
be: 6,707 spawn points against `MAX_OPTIONS`' 2,000, so a flat list would drop
two thirds of the world and say nothing about which two thirds.

ONE DEFECT IN ALREADY-MERGED CODE, AND IT WOULD HAVE BROKEN EVERYTHING

The protocol pin never left 5. `uo_link_config.protocol` reaches the sidecar as
`X-UOLink-Version` on every REST call and an exact mismatch is a 409, so from
Phase 11a onward every sidecar call on a real deployment would have been refused
-- the whole event plane dead, loudly, for a reason nobody would look here for.
11a took the wire to 6 and 12a to 7; neither moved the pin, in either of the two
places this repo declares it. It survived both because both live walks set the
column by hand while standing the rig up, which is exactly what makes a migration
nobody runs invisible. All three sites go to 7.

The test that guards them is worth understanding before trusting it:
`schemaFragment.test.js` asserts the three declarations agree WITH EACH OTHER --
a real check they once failed -- but all three being equally stale passes it, and
nothing in this repo can anchor it to the wire. Recorded in the model's own
header so the next reader knows.

CHECKS

`npm test`: 620 pass, 0 fail (was 605). `check:imports` and `check:externals`
clean; the client builds and its 42 tests pass. `check:swagger` reports the
fragment stale -- it is ALREADY stale on `edge` (verified by stashing this
branch's changes and re-running) and this phase adds no route, so it is left
alone rather than regenerated inside an unrelated change.

Two bugs the new tests caught in this branch's own code before it left: `counted()`
returns `.count` and the grant read `.value`, so every grant went out with
`amount: undefined` and the non-stackable guard never fired; and `optionalInt`'s
`ok` was ignored, so a bad hue passed silently instead of refusing.

Refs: docs/link/v7.md §11-§14, docs/website/EVENTS_PLAN.md Phase 12b

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016wDDVXWMDz82WqE1i969r4

Merge pull request 'feat(events): what an author borrows, and two one-shots (Phase 12b)' (#32) from feature/events-p12b-borrowed-and-oneshots into edge ... c289586a3d

Reviewed-on: #32

fix(events): the atlas import, and a teardown that was a no-op (Phase 16a) ... 8def6e19f4

Two defects the acceptance walk found in shipped code, both invisible to the
suites that were green on either side of them.

**The spawn atlas cannot import on a stock ServUO tree.** `spawnAtlasSource.js`
dedupes decoration types with a case-SENSITIVE `Map`, but `shard_decor_types.type`
is a PRIMARY KEY under MariaDB's default `..._ai_ci` collation, which folds case.
Stock 57.4's own `Data/Decoration/` names four types under two spellings each
(CheckerBoard/Checkerboard, ChessBoard/Chessboard, MetalChest/Metalchest,
SpinningWheelEastAddon/SpinningwheelEastAddon), and in every pair exactly one is a
real class. The second row raised `1062 Duplicate entry` and took the WHOLE import
transaction down. The blast radius is not decoration: with no atlas, EVERY option
source answers empty and no Phase 12 world verb can be authored at all.

The shard end already knew — `BridgeWorld.cs` resolves a decor type with
`FindTypeByName(name, ignoreCase: true)` and its comment says the atlas and the
decoration files disagree about casing. Folding here is the two ends agreeing.

**Teardown of every world verb was a no-op that reported success.** `revertOwned`
forwarded core's `idempotencyKey` as the despawn's OWN key — and core's key is the
step's, the one `placeOwned` spawned under. `BridgeIdempotency` keys on the key
alone, so the despawn was taken for a repeat and answered with the SPAWN's stored
reply; `OnDespawn` never ran. Core read `ok` with no `refused` and marked every
row `reverted` while the shard still held every object.

Measured on the rig: ledger `world | reverted | 21`, shard `world.owned` 21 alive
with `pruned: 0`, and the identical despawn re-sent with a fresh key removed all
21. It affected all five world verbs, so an invasion's creatures, boss, oracle,
gate and decoration stayed in the world for ever while the console reported a
clean teardown.

`MODULE_API.md` says what that key is for and it is not this: it identifies a
dispatch core never learned the outcome of, so the module can ask about it. No key
is needed on a despawn — a repeat answers `gone`, which both ends already treat as
success — and dropping it also makes the documented empty-`resources` case work,
since no serials means "everything this run owns". The parameter is removed from
`despawnWorld`'s signature rather than left optional.

Both fixes are verified end to end against a real ServUO + sidecar + website rig:
the import now yields 309 decor types (was failing at 313 with 4 collisions),
6,455 spawn points, 800 creatures, 558 landmarks; and a full four-phase run's
teardown left the shard owning 0 objects.

Each new test was confirmed to FAIL without its fix.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016wDDVXWMDz82WqE1i969r4

Merge pull request 'fix(events): the atlas import, and a teardown that was a no-op (Phase 16a)' (#33) from fix/events-p16a-walk into edge ... c73d62e93a

Reviewed-on: #33

chore(ci): the core pin comes home to main (Phase 16b cutover) ... ea63ad019c

`ci/core-ref.json` pointed at a website `edge` sha for the length of the Event
System window (org lead, 2026-09-04), because `api.registerEventActions` exists
only from MODULE_API 1.10.0: under the old `main` pin the frozen-manifest job's
`register()` threw and this module did not load at all, so the job would have
been red by construction for eight phases while a real regression hid behind it.

The cutover put 1.10.0 on `main` (website#199, 655fbf3f), so the pin returns to
a `main` sha -- and this is the same move that turns the Integration kit green,
since `checkCoreApi` asserts equality against whatever core this pin names.

`routes.manifest.json` needed NO regeneration. The frozen-manifest job's own
steps were run against this exact ref -- core's manifest alone, the module
installed, core's manifest again, then `frozenManifest.js --check` -- and it
answered `routes.manifest.json is current, 73 routes, all documented`. So the
file's own "commit both together" instruction had nothing to pair with this
time. website's `main` and `edge` are the identical tree (930422ff), which is
why the measurement taken on the branch holds for the merge.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016wDDVXWMDz82WqE1i969r4

whitlocktech approved these changes 2026-09-10 01:23:23 +00:00

whitlocktech merged commit bbaf08f67c into main 2026-09-10 01:23:39 +00:00

whitlocktech referenced this issue from a commit 2026-09-10 01:23:40 +00:00

Merge pull request 'feat(events): the UO half of the Event System, and the core pin comes home (Phase 16b cutover, 3 of 6)' (#34) from chore/events-cutover-repin into main

whitlocktech deleted branch chore/events-cutover-repin 2026-09-10 01:23:40 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

whitlocktech

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ksfixitman whitlocktech wtclaude

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RunicGateway/Module-uo#34

No description provided.