Merge pull request 'ci(pr-checks): cache cargo with rust-cache so the cache stops growing' (#44) from chore/ci-self-cleanup into main

Reviewed-on: #44
Reviewed-by: Colby Whitlock <whitlocktech@gmail.com>

.gitea/workflows/pr-checks.yml

@@ -89,19 +89,16 @@ jobs:
           rustup component add rustfmt clippy
           cargo --version && cargo fmt --version && cargo clippy --version
 
-      # Keyed on Cargo.lock: dependency builds are reused until a dep actually
-      # changes. A cache miss only makes the run slower, never wrong.
-      - name: Cache cargo registry and build dir
+      # Dependency builds are reused until a dep actually changes; a cache miss
+      # only makes the run slower, never wrong. rust-cache rather than a plain
+      # actions/cache of target/: it strips this crate's own artifacts and
+      # anything stale before saving, and saves only on a miss. The plain cache
+      # restored the previous target/ and re-saved all of it under every new
+      # Cargo.lock, so each entry carried every older build and the runner's
+      # cache grew without bound.
+      - name: Cache cargo registry and dependency builds
         if: ${{ steps.detect.outputs.crate == 'true' }}
-        uses: actions/cache@v4
-        with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target
-          key: ${{ runner.os }}-cargo-${{ hashFiles('Cargo.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-cargo-
+        uses: Swatinem/rust-cache@v2
 
       # Cheapest gate first — parses only, no compile, so a formatting slip
       # fails in seconds instead of after a full build.

src/cli.rs

@@ -56,7 +56,7 @@ pub enum PatchChoice {
     No,
 }
 
-/// Which game's shard side this run is about (docs/modules/rust/PLAN.md §34.2.3). ServUO is the
+/// Which game this run sets up (docs/modules/rust/PLAN.md §34.2.3). ServUO is the
 /// default, so every command line written before Rust existed means exactly what it meant.
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum Game {
@@ -94,7 +94,8 @@ pub struct Cli {
     pub patches_unsupported_servuo: bool,
     /// `--host <name>`: the hostname to print in the website URLs.
     pub host: Option<String>,
-    /// `--site-url <url>`: the site's base URL, for the Admin → Shard (uo-link) link.
+    /// `--site-url <url>`: the site's base URL, printed as a link to the admin page that takes
+    /// the values.
     pub site_url: Option<String>,
     /// `--yes`: assume the default answer to every prompt.
     pub assume_yes: bool,
@@ -128,7 +129,7 @@ impl Default for Cli {
 }
 
 pub const USAGE: &str = "\
-Runic Gateway installer — connects a ServUO shard, or Rust servers, to a Runic
+Runic Gateway installer — connects a ServUO server, or Rust servers, to a Runic
 Gateway website.
 
 Usage: runicgateway-installer <COMMAND> [OPTIONS]
@@ -144,7 +145,7 @@ Commands:
                removes only its own plugin file and keeps the plugin config.
 
 Options:
-      --game <servuo|rust>           Which game's shard side. Default servuo.
+      --game <servuo|rust>           Which game this run sets up. Default servuo.
       --verify                       install, update. Dry run: report every
                                      change that would be made, write nothing.
       --servuo <PATH>                install, doctor, update. The ServUO root,
@@ -161,7 +162,7 @@ Options:
       --host <NAME>                  install. The hostname to print in the
                                      website URLs.
       --site-url <URL>               install. Your site's base URL, for the
-                                     Admin → Shard (uo-link) link.
+                                     admin page link it prints at the end.
       --yes                          Assume the default answer to every prompt.
                                      On uninstall it means yes: that prompt
                                      defaults to no, and typing `uninstall
@@ -194,7 +195,7 @@ Environment:
                            set it.
 
 The installer never contacts your website, never deletes anything from your
-ServUO tree, and never starts or stops your shard.
+ServUO tree, and never starts or stops your game server.
 ";
 
 /// Parses arguments **without** the program name.