wtclaude
f2e59a2426
All checks were successful
PR checks / checks (pull_request) Successful in 9m46s
PLAN.md §13 phase 12, the last one. Four decisions of record, D54–D57, taking the count to fifty-seven; recorded in §6, "How phase 12 delivered it". A two-stage Dockerfile, a pull-only docker-compose.yml carrying both bind mounts, .env.example, the workflow that publishes and deploys, CONTRIBUTING.md, the community-health files this was the only repository of the ten to lack, and DEPLOY.md. D54 — a merge deploys, amending D6. build-image.yml pushes runicgateway-site:latest and :sha-<7>, then rolls the container over on the `rgcom` runner out of /opt/runicgateway.com, and waits for the container's own healthcheck rather than for `up -d` to return. D55 — the site runs on its own host behind a generic reverse proxy, so DEPLOY.md states the four requirements rather than one worked example, and the container binds 127.0.0.1 so the safe configuration is the default. D56 — @astrojs/node derives the request protocol from req.socket.encrypted and never reads x-forwarded-proto, so behind a TLS-terminating proxy the browser sends Origin: https://… while the container computes http://… and Astro's CSRF check compares them for equality. Every beta signup, from every visitor, was answered 403. serve.mjs now normalises both forwarded headers, unconditionally — the image should deploy and work. Two assertions in test/headers.test.mjs hold both halves. D57 — DEPLOY.md rather than a README section; SECURITY.md and CODE_OF_CONDUCT.md are pointers to the org's copies rather than copies, because a copy would hard-code the contact address D13 confines to brand.json. Verified: npm run verify green (eleven checks, 36 unit tests, 7 served tests, astro check 0 errors). The image was built and run with both mounts — a mounted brand reached 51 files and all 50 search pages, /brand/* fell back per file, a proxy-shaped signup reached the store, and the export CLI wrote both Play files to the host mount. docker compose config caught a YAML trap in the healthcheck: a block sequence reads the `: ` in `r.ok ? 0 : 1` as a mapping. Co-Authored-By: Claude <noreply@anthropic.com>
43 lines
1.6 KiB
Markdown
43 lines
1.6 KiB
Markdown
<!--
|
|
Thanks for contributing to Runic Gateway!
|
|
Please fill out the sections below and check every box before requesting review.
|
|
|
|
Merging to main publishes: it builds the image, pushes it to the registry and
|
|
deploys the site. There is no separate release step. See DEPLOY.md.
|
|
-->
|
|
|
|
## What & why
|
|
|
|
<!-- What does this PR change, and why? Link any related issue: "Closes #123". -->
|
|
|
|
## How it was tested
|
|
|
|
<!--
|
|
`npm run verify` output is the baseline. If the change touches a page, say what
|
|
you looked at and at what width; if it touches the container, say whether you
|
|
built and ran the image.
|
|
-->
|
|
|
|
## Checklist
|
|
|
|
- [ ] I have read [CONTRIBUTING.md](CONTRIBUTING.md).
|
|
- [ ] `npm run verify` passes locally (all eleven checks and both test suites).
|
|
- [ ] No fact is stated in prose — versions and platform facts come from `src/data/platform.json`.
|
|
- [ ] `PLAN.md` still describes what this repository does; a decision it records is either
|
|
unchanged or amended here, with the reasoning.
|
|
- [ ] My commits are reasonably scoped, with Conventional Commit messages.
|
|
|
|
## AI-assisted contributions (required)
|
|
|
|
This project **requires disclosure of AI tool usage**. Please pick one:
|
|
|
|
- [ ] No AI tools were used to produce this contribution.
|
|
- [ ] AI tools were used. Tool(s): `___________`. I have reviewed and understand
|
|
every change, and take responsibility for it. AI-authored commits are
|
|
marked with a `Co-Authored-By` / `Assisted-By` trailer.
|
|
|
|
## License
|
|
|
|
- [ ] I agree that my contribution is licensed under this project's license
|
|
(**GNU GPL v3.0 or later**), and I have the right to contribute it.
|